From: Jonathan Cameron <jic23@kernel.org>
To: Alexander Koch <mail@alexanderkoch.net>,
Martin Kepplinger <martink@posteo.de>
Cc: knaack.h@gmx.de, lars@metafoo.de,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Michael Hornung <mhornung.linux@gmail.com>,
dannenberg@ti.com, balbi@ti.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] iio: light: opt3001: enable operation w/o IRQ
Date: Sun, 24 Jan 2016 14:55:32 +0000 [thread overview]
Message-ID: <56A4E5E4.2070608@kernel.org> (raw)
In-Reply-To: <56A3CC8B.1020205@alexanderkoch.net>
On 23/01/16 18:55, Alexander Koch wrote:
> Am 18.01.2016 um 18:07 schrieb Martin Kepplinger:
>> Am 2016-01-16 um 17:14 schrieb Alexander Koch:
>>> Enable operation of the TI OPT3001 light sensor without having an
>>> interrupt line available to connect the INT pin to.
>>>
>>> In this operation mode, we issue a conversion request and simply wait
>>> for the conversion time available as timeout value, determined from
>>> integration time configuration and the worst-case time given in the data
>>> sheet (sect. 6.5, table on p. 5):
>>>
>>> short integration time (100ms): 110ms + 3ms = 113ms
>>> long integration time (800ms): 880ms + 3ms = 883ms
>>>
>>> This change is transparent as behaviour defaults to using the interrupt
>>> method if an interrupt no. is configured via device tree. Interrupt-less
>>> operation mode is performed when no valid interrupt no. is given.
>>>
>>> Signed-off-by: Alexander Koch <mail@alexanderkoch.net>
>>> Signed-off-by: Michael Hornung <mhornung.linux@gmail.com>
>>> ---
>>> drivers/iio/light/opt3001.c | 137 ++++++++++++++++++++++++++++++--------------
>>> 1 file changed, 95 insertions(+), 42 deletions(-)
>>>
>>
>> Looks ok to me, although I didn't verify anything. Not very important
>> suggestions for changes inline
>
> Thanks! Suggestions noted but if nobody objects I'd stick with v2 as I'm
> hoping to have it accepted in the merge window for 4.5.
Sorry Alex,
The IIO merge window for a given cycle closes at least a week before Linus
announces the opening of the main merge window. This is partly due to the
path that IIO patches take to Linus (via Greg KH who operates a policy of
not taking anything after Linus starts hinting that the final RC for the
previous version is out) and partly as it's good general best practice
as it leaves some time for patches to sit in linux-next and get hammered
by the autobuilders, identifying any merge conflicts etc.
So this is firmly 4.6 material now anyway so we have lots of time to
dot the 'i's and cross the 't's!
(If it had been marginal I 'might' have enacted Martin's suggestions
as I applied the patch) but no point in taking the risk I might mess
it up so early in a cycle!
Jonathan
>
>
> Regards
>
> Alex
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-01-24 14:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-16 16:14 [PATCH v2 0/3] iio: light: opt3001: Enable operation w/o IRQ Alexander Koch
2016-01-16 16:14 ` [PATCH v2 1/3] iio: light: opt3001: extract int. time constants Alexander Koch
2016-01-24 15:01 ` Jonathan Cameron
2016-01-29 17:59 ` Andreas Dannenberg
2016-01-16 16:14 ` [PATCH v2 2/3] iio: light: opt3001: trivial type refactoring Alexander Koch
2016-01-24 15:02 ` Jonathan Cameron
2016-01-29 18:00 ` Andreas Dannenberg
2016-01-16 16:14 ` [PATCH v2 3/3] iio: light: opt3001: enable operation w/o IRQ Alexander Koch
2016-01-18 17:07 ` Martin Kepplinger
2016-01-23 18:55 ` Alexander Koch
2016-01-24 14:55 ` Jonathan Cameron [this message]
2016-01-24 15:07 ` Jonathan Cameron
2016-01-29 18:01 ` Andreas Dannenberg
2016-01-30 16:27 ` Jonathan Cameron
2016-01-29 18:05 ` [PATCH v2 0/3] iio: light: opt3001: Enable " Andreas Dannenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A4E5E4.2070608@kernel.org \
--to=jic23@kernel.org \
--cc=balbi@ti.com \
--cc=dannenberg@ti.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@alexanderkoch.net \
--cc=martink@posteo.de \
--cc=mhornung.linux@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).