linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Jonathan Cameron" <jic23@jic23.retrosnub.co.uk>,
	"Sean Nyekjær" <sean.nyekjaer@prevas.dk>,
	linux-iio@vger.kernel.org
Subject: Re: [RFC 1/2] iio: core: added support for a single output that supports both current and voltage
Date: Sun, 24 Jan 2016 15:14:02 +0000	[thread overview]
Message-ID: <56A4EA3A.3030200@kernel.org> (raw)
In-Reply-To: <1F14D1A1-22FE-4A57-9EA1-2F87E23C6AC9@jic23.retrosnub.co.uk>

On 22/01/16 16:49, Jonathan Cameron wrote:
> 
> 
> On 22 January 2016 14:37:33 GMT+00:00, "Sean Nyekjær" <sean.nyekjaer@prevas.dk> wrote:
>> Hi
>>
>> How do you register two channels for one channel?
I got this a bit backwards reading it on the phone and thought we were dealing
with an ADC rather than a DAC (oops!) I'm going to move the rest of this
discussion into the reply to patch 2 as it will make more sense alongside
your usecase there.

<snip>
> 
> 
>> Please give a quick example
> Phone only so will get back to you tomorrow!
> 
>>
>> /Sean
>>
>> On 2016-01-22 15:14, Jonathan Cameron wrote:
>>> Hi
>>>
>>> Quick gut feel response. Register two channels.
>>>
>>> Jonathan
>>>
>>> On 22 January 2016 12:54:55 GMT+00:00, Sean Nyekjaer 
>>> <sean.nyekjaer@prevas.dk> wrote:
>>>
>>>     Signed-off-by: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
>>>     ---
>>>       drivers/iio/industrialio-core.c | 2 ++
>>>       include/linux/iio/iio.h         | 1 +
>>>       include/uapi/linux/iio/types.h  | 1 +
>>>       3 files changed, 4 insertions(+)
>>>
>>>     diff --git a/drivers/iio/industrialio-core.c
>> b/drivers/iio/industrialio-core.c
>>>     index fd01f34..5e1beea 100644
>>>     --- a/drivers/iio/industrialio-core.c
>>>     +++ b/drivers/iio/industrialio-core.c
>>>     @@ -77,6 +77,7 @@ static const char * const
>> iio_chan_type_name_spec[] = {
>>>        [IIO_VELOCITY] = "velocity",
>>>        [IIO_CONCENTRATION] = "concentration",
>>>        [IIO_RESISTANCE] = "resistance",
>>>     + [IIO_DUAL_VOLTCUR] = "voltcur",
>>>       };
>>>       
>>>       static const char * const iio_modifier_names[] = {
>>>     @@ -146,6 +147,7 @@ static const char * const
>> iio_chan_info_postfix[] = {
>>>        [IIO_CHAN_INFO_DEBOUNCE_TIME] = "debounce_time",
>>>        [IIO_CHAN_INFO_CALIBEMISSIVITY] = "calibemissivity",
>>>       
>>>     [IIO_CHAN_INFO_OVERSAMPLING_RATIO] = "oversampling_ratio",
>>>     + [IIO_CHAN_INFO_MODE] = "mode",
>>>       };
>>>       
>>>       /**
>>>     diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
>>>     index b589411..ef4c7cd9 100644
>>>     --- a/include/linux/iio/iio.h
>>>     +++ b/include/linux/iio/iio.h
>>>     @@ -46,6 +46,7 @@ enum iio_chan_info_enum {
>>>        IIO_CHAN_INFO_DEBOUNCE_TIME,
>>>        IIO_CHAN_INFO_CALIBEMISSIVITY,
>>>        IIO_CHAN_INFO_OVERSAMPLING_RATIO,
>>>     + IIO_CHAN_INFO_MODE,
>>>       };
>>>       
>>>       enum iio_shared_by {
>>>     diff --git a/include/uapi/linux/iio/types.h
>> b/include/uapi/linux/iio/types.h
>>>     index 7c63bd6..81e6a2a 100644
>>>     --- a/include/uapi/linux/iio/types.h
>>>     +++ b/include/uapi/linux/iio/types.h
>>>     @@ -37,6 +37,7 @@ enum iio_chan_type {
>>>        IIO_VELOCITY,
>>>        IIO_CONCENTRATION,
>>>        IIO_RESISTANCE,
>>>     + IIO_DUAL_VOLTCUR,
>>>       };
>>>       
>>>       enum iio_modifier {
>>>
>>>
>>> -- 
>>> Sent from my Android device with K-9 Mail. Please excuse my brevity. 
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


      reply	other threads:[~2016-01-24 15:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-22 12:54 [RFC 1/2] iio: core: added support for a single output that supports both current and voltage Sean Nyekjaer
2016-01-22 12:54 ` [RFC 2/2] iio: ad5755: added support for switching between voltage and current output Sean Nyekjaer
2016-01-24 15:49   ` Jonathan Cameron
2016-01-25 15:05     ` Sean Nyekjær
2016-01-25 17:17       ` Jonathan Cameron
2016-01-25 16:00   ` Lars-Peter Clausen
2016-01-26  6:15     ` Sean Nyekjær
     [not found] ` <2C284AAE-21FB-4EFE-AD1C-2F010B15C845@jic23.retrosnub.co.uk>
2016-01-22 14:37   ` [RFC 1/2] iio: core: added support for a single output that supports both current and voltage Sean Nyekjær
2016-01-22 16:49     ` Jonathan Cameron
2016-01-24 15:14       ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A4EA3A.3030200@kernel.org \
    --to=jic23@kernel.org \
    --cc=jic23@jic23.retrosnub.co.uk \
    --cc=linux-iio@vger.kernel.org \
    --cc=sean.nyekjaer@prevas.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).