From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:53302 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756885AbcA3PjW (ORCPT ); Sat, 30 Jan 2016 10:39:22 -0500 Subject: Re: [patch] iio: inkern: fix a NULL dereference on error To: Dan Carpenter , Marek Belisko References: <20160126092521.GC15717@mwanda> Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org From: Jonathan Cameron Message-ID: <56ACD925.3010006@kernel.org> Date: Sat, 30 Jan 2016 15:39:17 +0000 MIME-Version: 1.0 In-Reply-To: <20160126092521.GC15717@mwanda> Content-Type: text/plain; charset=windows-1252 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 26/01/16 09:25, Dan Carpenter wrote: > In twl4030_bci_probe() there are some failure paths where we call > iio_channel_release() with a NULL pointer. (Apparently, that driver can > opperate without a valid channel pointer). Let's fix it by adding a > NULL check in iio_channel_release(). > > Fixes: 2202e1fc5a29 ('drivers: power: twl4030_charger: fix link problems when building as module') > Signed-off-by: Dan Carpenter > Whilst I'd prefer to see the driver calling this have balanced calls, I can see that having this sanity check in here is probably sensible. Applied to the fixes-togreg tree and marked for stable. Jonathan > diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c > index 80fbbfd..734a004 100644 > --- a/drivers/iio/inkern.c > +++ b/drivers/iio/inkern.c > @@ -349,6 +349,8 @@ EXPORT_SYMBOL_GPL(iio_channel_get); > > void iio_channel_release(struct iio_channel *channel) > { > + if (!channel) > + return; > iio_device_put(channel->indio_dev); > kfree(channel); > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >