[PATCH 04/22] staging: iio: Fix dependencies for !HAS_IOMEM archs

[PATCH 04/22] staging: iio: Fix dependencies for !HAS_IOMEM archs

[Richard Weinberger]

Not every arch has io memory.
So, unbreak the build by fixing the dependencies.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/staging/iio/adc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/iio/adc/Kconfig b/drivers/staging/iio/adc/Kconfig
index 58d4517..b9519be 100644
--- a/drivers/staging/iio/adc/Kconfig
+++ b/drivers/staging/iio/adc/Kconfig
@@ -6,6 +6,7 @@ menu "Analog to digital converters"
 config AD7606
 	tristate "Analog Devices AD7606 ADC driver"
 	depends on GPIOLIB || COMPILE_TEST
+	depends on HAS_IOMEM
 	select IIO_BUFFER
 	select IIO_TRIGGERED_BUFFER
 	help
-- 
1.8.4.5

Re: [PATCH 04/22] staging: iio: Fix dependencies for !HAS_IOMEM archs

[Geert Uytterhoeven]

On Mon, Jan 25, 2016 at 11:24 PM, Richard Weinberger <richard@nod.at> wrote:
> Not every arch has io memory.
> So, unbreak the build by fixing the dependencies.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 04/22] staging: iio: Fix dependencies for !HAS_IOMEM archs

[Jonathan Cameron]

On 26/01/16 10:59, Geert Uytterhoeven wrote:
> On Mon, Jan 25, 2016 at 11:24 PM, Richard Weinberger <richard@nod.at> wrote:
>> Not every arch has io memory.
>> So, unbreak the build by fixing the dependencies.
>>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
> 
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied to the same obscure branch of iio.git as patch 6.
Will unwind this cross merge window mess in my tree sometime
in the next week or so.

Thanks,

Jonathan
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

[PATCH 06/22] iio: adc: Fix dependencies for !HAS_IOMEM archs

[Richard Weinberger]

Not every arch has io memory.
So, unbreak the build by fixing the dependencies.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/iio/adc/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 605ff42..283ded7 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -175,6 +175,7 @@ config DA9150_GPADC
 config EXYNOS_ADC
 	tristate "Exynos ADC driver support"
 	depends on ARCH_EXYNOS || ARCH_S3C24XX || ARCH_S3C64XX || (OF && COMPILE_TEST)
+	depends on HAS_IOMEM
 	help
 	  Core support for the ADC block found in the Samsung EXYNOS series
 	  of SoCs for drivers such as the touchscreen and hwmon to use to share
@@ -207,6 +208,7 @@ config INA2XX_ADC
 config IMX7D_ADC
 	tristate "IMX7D ADC driver"
 	depends on ARCH_MXC || COMPILE_TEST
+	depends on HAS_IOMEM
 	help
 	  Say yes here to build support for IMX7D ADC.
 
@@ -409,6 +411,7 @@ config TWL6030_GPADC
 config VF610_ADC
 	tristate "Freescale vf610 ADC driver"
 	depends on OF
+	depends on HAS_IOMEM
 	select IIO_BUFFER
 	select IIO_TRIGGERED_BUFFER
 	help
-- 
1.8.4.5

Re: [PATCH 06/22] iio: adc: Fix dependencies for !HAS_IOMEM archs

[Jonathan Cameron]

On 25/01/16 22:24, Richard Weinberger wrote:
> Not every arch has io memory.
> So, unbreak the build by fixing the dependencies.
> 
> Signed-off-by: Richard Weinberger <richard@nod.at>
Applied to the temporary branch for post 4.5 fixes
(as I haven't unwound that yet) for iio.git.
> ---
>  drivers/iio/adc/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 605ff42..283ded7 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -175,6 +175,7 @@ config DA9150_GPADC
>  config EXYNOS_ADC
>  	tristate "Exynos ADC driver support"
>  	depends on ARCH_EXYNOS || ARCH_S3C24XX || ARCH_S3C64XX || (OF && COMPILE_TEST)
> +	depends on HAS_IOMEM
>  	help
>  	  Core support for the ADC block found in the Samsung EXYNOS series
>  	  of SoCs for drivers such as the touchscreen and hwmon to use to share
> @@ -207,6 +208,7 @@ config INA2XX_ADC
>  config IMX7D_ADC
>  	tristate "IMX7D ADC driver"
>  	depends on ARCH_MXC || COMPILE_TEST
> +	depends on HAS_IOMEM
>  	help
>  	  Say yes here to build support for IMX7D ADC.
>  
> @@ -409,6 +411,7 @@ config TWL6030_GPADC
>  config VF610_ADC
>  	tristate "Freescale vf610 ADC driver"
>  	depends on OF
> +	depends on HAS_IOMEM
>  	select IIO_BUFFER
>  	select IIO_TRIGGERED_BUFFER
>  	help
> 

[PATCH 16/22] iio: imu: Fix dependencies for !HAS_IOMEM archs

[Richard Weinberger]

Not every arch has io memory.
While the driver has correct dependencies the select statement
will bypass the HAS_IOMEM dependency.
So, unbreak the build by rendering it into a real dependency.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/iio/imu/inv_mpu6050/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/imu/inv_mpu6050/Kconfig b/drivers/iio/imu/inv_mpu6050/Kconfig
index 48fbc0b..8f8d137 100644
--- a/drivers/iio/imu/inv_mpu6050/Kconfig
+++ b/drivers/iio/imu/inv_mpu6050/Kconfig
@@ -5,9 +5,9 @@
 config INV_MPU6050_IIO
 	tristate "Invensense MPU6050 devices"
 	depends on I2C && SYSFS
+	depends on I2C_MUX
 	select IIO_BUFFER
 	select IIO_TRIGGERED_BUFFER
-	select I2C_MUX
 	help
 	  This driver supports the Invensense MPU6050 devices.
 	  This driver can also support MPU6500 in MPU6050 compatibility mode
-- 
1.8.4.5

Re: [PATCH 16/22] iio: imu: Fix dependencies for !HAS_IOMEM archs

[Paul Bolle]

On ma, 2016-01-25 at 23:24 +0100, Richard Weinberger wrote:
> --- a/drivers/iio/imu/inv_mpu6050/Kconfig
> +++ b/drivers/iio/imu/inv_mpu6050/Kconfig

>  config INV_MPU6050_IIO
>  	tristate "Invensense MPU6050 devices"
>  	depends on I2C && SYSFS
> +	depends on I2C_MUX

Nit: if I parsed the v4.5-rc1 tree correctly I2C_MUX depends I2C. So
just
	depends on I2C_MUX && SYSFS

should also do the trick. Is it clearer to mention both I2C and I2C_MUX
explicitly?

(Likewise for 17/22.)

>  	select IIO_BUFFER
>  	select IIO_TRIGGERED_BUFFER
> -	select I2C_MUX
>  	help
>  	  This driver supports the Invensense MPU6050 devices.

(evolution 3.16.5 hates replying to plain text messages, so I've lost a
line of context after fiddling with your message here.)


Paul Bolle

Re: [PATCH 16/22] iio: imu: Fix dependencies for !HAS_IOMEM archs

[Richard Weinberger]

Am 26.01.2016 um 01:15 schrieb Paul Bolle:
> On ma, 2016-01-25 at 23:24 +0100, Richard Weinberger wrote:
>> --- a/drivers/iio/imu/inv_mpu6050/Kconfig
>> +++ b/drivers/iio/imu/inv_mpu6050/Kconfig
> 
>>  config INV_MPU6050_IIO
>>  	tristate "Invensense MPU6050 devices"
>>  	depends on I2C && SYSFS
>> +	depends on I2C_MUX
> 
> Nit: if I parsed the v4.5-rc1 tree correctly I2C_MUX depends I2C. So
> just
> 	depends on I2C_MUX && SYSFS
> 
> should also do the trick. Is it clearer to mention both I2C and I2C_MUX
> explicitly?

I don't have a strong opinion on that. In general I'm a fan of explicit
dependencies but in this case, you are right, also an implicit one should to it.
Let's see what maintainers think. :-)

Thanks,
//richard

Re: [PATCH 16/22] iio: imu: Fix dependencies for !HAS_IOMEM archs

[Jonathan Cameron]

On 26/01/16 08:17, Richard Weinberger wrote:
> Am 26.01.2016 um 01:15 schrieb Paul Bolle:
>> On ma, 2016-01-25 at 23:24 +0100, Richard Weinberger wrote:
>>> --- a/drivers/iio/imu/inv_mpu6050/Kconfig
>>> +++ b/drivers/iio/imu/inv_mpu6050/Kconfig
>>
>>>  config INV_MPU6050_IIO
>>>  	tristate "Invensense MPU6050 devices"
>>>  	depends on I2C && SYSFS
>>> +	depends on I2C_MUX
>>
>> Nit: if I parsed the v4.5-rc1 tree correctly I2C_MUX depends I2C. So
>> just
>> 	depends on I2C_MUX && SYSFS
>>
>> should also do the trick. Is it clearer to mention both I2C and I2C_MUX
>> explicitly?
> 
> I don't have a strong opinion on that. In general I'm a fan of explicit
> dependencies but in this case, you are right, also an implicit one should to it.
> Let's see what maintainers think. :-)
I find it hard to care ;)

Anyhow, the version as stands applied to the rather odd fixes-post-4.5rc1 branch
that I currently have in iio.git - will unwind that now we are post said version
sometime in next few days (this on is only there because I needed to take patch
06 through that branch).

Jonathan
> 
> Thanks,
> //richard
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>