linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Daniel Baluta <daniel.baluta@intel.com>,
	Matt Ranostay <mranostay@gmail.com>
Cc: "Cristina Moraru" <cristina.moraru09@gmail.com>,
	"Hartmut Knaack" <knaack.h@gmx.de>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
	"Ludovic Tancerel" <ludovic.tancerel@maplehightech.com>,
	geert@linux-m68k.org,
	"Krzysztof Kozłowski" <k.kozlowski@samsung.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"octavian.purdila@intel.com" <octavian.purdila@intel.com>
Subject: Re: [PATCH 2/2] iio: si7005: add support for Hoperf th02
Date: Sat, 30 Jan 2016 16:12:35 +0000	[thread overview]
Message-ID: <56ACE0F3.30708@kernel.org> (raw)
In-Reply-To: <CAEnQRZDACDTnmMdnefaWEK_Mt-5CSP1bndXERVseuJ3KLWbCHQ@mail.gmail.com>

On 27/01/16 09:13, Daniel Baluta wrote:
> On Wed, Jan 27, 2016 at 12:56 AM, Matt Ranostay <mranostay@gmail.com> wrote:
>> On Tue, Jan 26, 2016 at 12:21 PM, Cristina Moraru
>> <cristina.moraru09@gmail.com> wrote:
>>> This patch adds support for Hoperf th02 humidity and
>>> temperature sensor as it uses same register definitions
>>> as si7005
>>>
>>> th02 Datasheet: http://www.anglia-live.com/netalogue/pdfs/hrf/datasheets/TH02_V1.1.pdf
>>>
>>> Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
>>> ---
>>>  drivers/iio/humidity/Kconfig  | 3 ++-
>>>  drivers/iio/humidity/si7005.c | 1 +
>>>  2 files changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
>>> index c1f3a21..866dda1 100644
>>> --- a/drivers/iio/humidity/Kconfig
>>> +++ b/drivers/iio/humidity/Kconfig
>>> @@ -43,7 +43,8 @@ config SI7005
>>>           humidity and temperature sensor.
>>>
>>>           To compile this driver as a module, choose M here: the module
>>> -         will be called si7005.
>>> +         will be called si7005. This driver also
>>> +         supports Hoperf TH02 Humidity and Temperature Sensor.
>>
>> This probably shouldn't be changing the Kconfig description. Since if
>> every driver added a line for each device/variant it supported
>> everything would get quite wordy.
> 
> Wordy is good :). We usually add all the supported chips in the Kconfig.
> See for example entries for BMC150_ACCEL or IIO_ST_ACCEL_3AXIS.
Absolutely - never mind burning words that are hidden under help ;)

Jonathan
> 
> thanks,
> Daniel.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


  reply	other threads:[~2016-01-30 16:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-26 20:21 [PATCH 2/2] iio: si7005: add support for Hoperf th02 Cristina Moraru
2016-01-26 22:56 ` Matt Ranostay
2016-01-27  9:13   ` Daniel Baluta
2016-01-30 16:12     ` Jonathan Cameron [this message]
2016-01-30 16:13 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56ACE0F3.30708@kernel.org \
    --to=jic23@kernel.org \
    --cc=cristina.moraru09@gmail.com \
    --cc=daniel.baluta@intel.com \
    --cc=geert@linux-m68k.org \
    --cc=k.kozlowski@samsung.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.tancerel@maplehightech.com \
    --cc=mranostay@gmail.com \
    --cc=octavian.purdila@intel.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).