* [PATCH 2/2] iio: si7005: add support for Hoperf th02
@ 2016-01-26 20:21 Cristina Moraru
2016-01-26 22:56 ` Matt Ranostay
2016-01-30 16:13 ` Jonathan Cameron
0 siblings, 2 replies; 5+ messages in thread
From: Cristina Moraru @ 2016-01-26 20:21 UTC (permalink / raw)
To: jic23, knaack.h, lars, pmeerw, ludovic.tancerel, mranostay, geert,
k.kozlowski, linux-kernel, linux-iio, octavian.purdila,
daniel.baluta
Cc: Cristina Moraru
This patch adds support for Hoperf th02 humidity and
temperature sensor as it uses same register definitions
as si7005
th02 Datasheet: http://www.anglia-live.com/netalogue/pdfs/hrf/datasheets/TH02_V1.1.pdf
Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
---
drivers/iio/humidity/Kconfig | 3 ++-
drivers/iio/humidity/si7005.c | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
index c1f3a21..866dda1 100644
--- a/drivers/iio/humidity/Kconfig
+++ b/drivers/iio/humidity/Kconfig
@@ -43,7 +43,8 @@ config SI7005
humidity and temperature sensor.
To compile this driver as a module, choose M here: the module
- will be called si7005.
+ will be called si7005. This driver also
+ supports Hoperf TH02 Humidity and Temperature Sensor.
config SI7020
tristate "Si7013/20/21 Relative Humidity and Temperature Sensors"
diff --git a/drivers/iio/humidity/si7005.c b/drivers/iio/humidity/si7005.c
index 91972cc..98a022f 100644
--- a/drivers/iio/humidity/si7005.c
+++ b/drivers/iio/humidity/si7005.c
@@ -170,6 +170,7 @@ static int si7005_probe(struct i2c_client *client,
static const struct i2c_device_id si7005_id[] = {
{ "si7005", 0 },
+ { "th02", 0 },
{ }
};
MODULE_DEVICE_TABLE(i2c, si7005_id);
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] iio: si7005: add support for Hoperf th02
2016-01-26 20:21 [PATCH 2/2] iio: si7005: add support for Hoperf th02 Cristina Moraru
@ 2016-01-26 22:56 ` Matt Ranostay
2016-01-27 9:13 ` Daniel Baluta
2016-01-30 16:13 ` Jonathan Cameron
1 sibling, 1 reply; 5+ messages in thread
From: Matt Ranostay @ 2016-01-26 22:56 UTC (permalink / raw)
To: Cristina Moraru
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, ludovic.tancerel, geert,
Krzysztof Kozłowski, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, octavian.purdila, Daniel Baluta
On Tue, Jan 26, 2016 at 12:21 PM, Cristina Moraru
<cristina.moraru09@gmail.com> wrote:
> This patch adds support for Hoperf th02 humidity and
> temperature sensor as it uses same register definitions
> as si7005
>
> th02 Datasheet: http://www.anglia-live.com/netalogue/pdfs/hrf/datasheets/TH02_V1.1.pdf
>
> Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
> ---
> drivers/iio/humidity/Kconfig | 3 ++-
> drivers/iio/humidity/si7005.c | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
> index c1f3a21..866dda1 100644
> --- a/drivers/iio/humidity/Kconfig
> +++ b/drivers/iio/humidity/Kconfig
> @@ -43,7 +43,8 @@ config SI7005
> humidity and temperature sensor.
>
> To compile this driver as a module, choose M here: the module
> - will be called si7005.
> + will be called si7005. This driver also
> + supports Hoperf TH02 Humidity and Temperature Sensor.
This probably shouldn't be changing the Kconfig description. Since if
every driver added a line for each device/variant it supported
everything would get quite wordy.
>
> config SI7020
> tristate "Si7013/20/21 Relative Humidity and Temperature Sensors"
> diff --git a/drivers/iio/humidity/si7005.c b/drivers/iio/humidity/si7005.c
> index 91972cc..98a022f 100644
> --- a/drivers/iio/humidity/si7005.c
> +++ b/drivers/iio/humidity/si7005.c
> @@ -170,6 +170,7 @@ static int si7005_probe(struct i2c_client *client,
>
> static const struct i2c_device_id si7005_id[] = {
> { "si7005", 0 },
> + { "th02", 0 },
> { }
> };
> MODULE_DEVICE_TABLE(i2c, si7005_id);
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] iio: si7005: add support for Hoperf th02
2016-01-26 22:56 ` Matt Ranostay
@ 2016-01-27 9:13 ` Daniel Baluta
2016-01-30 16:12 ` Jonathan Cameron
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Baluta @ 2016-01-27 9:13 UTC (permalink / raw)
To: Matt Ranostay
Cc: Cristina Moraru, Jonathan Cameron, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, Ludovic Tancerel,
geert, Krzysztof Kozłowski, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, octavian.purdila@intel.com,
Daniel Baluta
On Wed, Jan 27, 2016 at 12:56 AM, Matt Ranostay <mranostay@gmail.com> wrote:
> On Tue, Jan 26, 2016 at 12:21 PM, Cristina Moraru
> <cristina.moraru09@gmail.com> wrote:
>> This patch adds support for Hoperf th02 humidity and
>> temperature sensor as it uses same register definitions
>> as si7005
>>
>> th02 Datasheet: http://www.anglia-live.com/netalogue/pdfs/hrf/datasheets/TH02_V1.1.pdf
>>
>> Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
>> ---
>> drivers/iio/humidity/Kconfig | 3 ++-
>> drivers/iio/humidity/si7005.c | 1 +
>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
>> index c1f3a21..866dda1 100644
>> --- a/drivers/iio/humidity/Kconfig
>> +++ b/drivers/iio/humidity/Kconfig
>> @@ -43,7 +43,8 @@ config SI7005
>> humidity and temperature sensor.
>>
>> To compile this driver as a module, choose M here: the module
>> - will be called si7005.
>> + will be called si7005. This driver also
>> + supports Hoperf TH02 Humidity and Temperature Sensor.
>
> This probably shouldn't be changing the Kconfig description. Since if
> every driver added a line for each device/variant it supported
> everything would get quite wordy.
Wordy is good :). We usually add all the supported chips in the Kconfig.
See for example entries for BMC150_ACCEL or IIO_ST_ACCEL_3AXIS.
thanks,
Daniel.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] iio: si7005: add support for Hoperf th02
2016-01-27 9:13 ` Daniel Baluta
@ 2016-01-30 16:12 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2016-01-30 16:12 UTC (permalink / raw)
To: Daniel Baluta, Matt Ranostay
Cc: Cristina Moraru, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Ludovic Tancerel, geert,
Krzysztof Kozłowski, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, octavian.purdila@intel.com
On 27/01/16 09:13, Daniel Baluta wrote:
> On Wed, Jan 27, 2016 at 12:56 AM, Matt Ranostay <mranostay@gmail.com> wrote:
>> On Tue, Jan 26, 2016 at 12:21 PM, Cristina Moraru
>> <cristina.moraru09@gmail.com> wrote:
>>> This patch adds support for Hoperf th02 humidity and
>>> temperature sensor as it uses same register definitions
>>> as si7005
>>>
>>> th02 Datasheet: http://www.anglia-live.com/netalogue/pdfs/hrf/datasheets/TH02_V1.1.pdf
>>>
>>> Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
>>> ---
>>> drivers/iio/humidity/Kconfig | 3 ++-
>>> drivers/iio/humidity/si7005.c | 1 +
>>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
>>> index c1f3a21..866dda1 100644
>>> --- a/drivers/iio/humidity/Kconfig
>>> +++ b/drivers/iio/humidity/Kconfig
>>> @@ -43,7 +43,8 @@ config SI7005
>>> humidity and temperature sensor.
>>>
>>> To compile this driver as a module, choose M here: the module
>>> - will be called si7005.
>>> + will be called si7005. This driver also
>>> + supports Hoperf TH02 Humidity and Temperature Sensor.
>>
>> This probably shouldn't be changing the Kconfig description. Since if
>> every driver added a line for each device/variant it supported
>> everything would get quite wordy.
>
> Wordy is good :). We usually add all the supported chips in the Kconfig.
> See for example entries for BMC150_ACCEL or IIO_ST_ACCEL_3AXIS.
Absolutely - never mind burning words that are hidden under help ;)
Jonathan
>
> thanks,
> Daniel.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] iio: si7005: add support for Hoperf th02
2016-01-26 20:21 [PATCH 2/2] iio: si7005: add support for Hoperf th02 Cristina Moraru
2016-01-26 22:56 ` Matt Ranostay
@ 2016-01-30 16:13 ` Jonathan Cameron
1 sibling, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2016-01-30 16:13 UTC (permalink / raw)
To: Cristina Moraru, knaack.h, lars, pmeerw, ludovic.tancerel,
mranostay, geert, k.kozlowski, linux-kernel, linux-iio,
octavian.purdila, daniel.baluta
On 26/01/16 20:21, Cristina Moraru wrote:
> This patch adds support for Hoperf th02 humidity and
> temperature sensor as it uses same register definitions
> as si7005
>
> th02 Datasheet: http://www.anglia-live.com/netalogue/pdfs/hrf/datasheets/TH02_V1.1.pdf
>
> Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
Applied to the togreg branch of iio.git -initially pushed out as testing
for the auto builders to play with it (not really relevant here, but such
is life ;)
Jonathan
> ---
> drivers/iio/humidity/Kconfig | 3 ++-
> drivers/iio/humidity/si7005.c | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
> index c1f3a21..866dda1 100644
> --- a/drivers/iio/humidity/Kconfig
> +++ b/drivers/iio/humidity/Kconfig
> @@ -43,7 +43,8 @@ config SI7005
> humidity and temperature sensor.
>
> To compile this driver as a module, choose M here: the module
> - will be called si7005.
> + will be called si7005. This driver also
> + supports Hoperf TH02 Humidity and Temperature Sensor.
>
> config SI7020
> tristate "Si7013/20/21 Relative Humidity and Temperature Sensors"
> diff --git a/drivers/iio/humidity/si7005.c b/drivers/iio/humidity/si7005.c
> index 91972cc..98a022f 100644
> --- a/drivers/iio/humidity/si7005.c
> +++ b/drivers/iio/humidity/si7005.c
> @@ -170,6 +170,7 @@ static int si7005_probe(struct i2c_client *client,
>
> static const struct i2c_device_id si7005_id[] = {
> { "si7005", 0 },
> + { "th02", 0 },
> { }
> };
> MODULE_DEVICE_TABLE(i2c, si7005_id);
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-30 16:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-26 20:21 [PATCH 2/2] iio: si7005: add support for Hoperf th02 Cristina Moraru
2016-01-26 22:56 ` Matt Ranostay
2016-01-27 9:13 ` Daniel Baluta
2016-01-30 16:12 ` Jonathan Cameron
2016-01-30 16:13 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).