From: Jonathan Cameron <jic23@kernel.org>
To: Adriana Reus <adriana.reus@intel.com>
Cc: linux-iio@vger.kernel.org, srinivas.pandruvada@linux.intel.com,
ggao@invensense.com
Subject: Re: [PATCH 2/5] iio: inv_mpu6050: Remove unused parameter
Date: Sat, 30 Jan 2016 17:18:11 +0000 [thread overview]
Message-ID: <56ACF053.2050807@kernel.org> (raw)
In-Reply-To: <1454147028-22449-3-git-send-email-adriana.reus@intel.com>
On 30/01/16 09:43, Adriana Reus wrote:
> The inv_check_and_setup_chip function does not use the i2c_device_id
> parameter. Therefore remove it.
>
> Signed-off-by: Adriana Reus <adriana.reus@intel.com>
This one stands just fine on it's own. Hence applied to the togreg branch
of iio.git - initially pushed out as testing for the autobuilders to
play with it.
Thanks,
Jonathan
> ---
> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> index 5fe1dd8..1121f4e 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> @@ -727,8 +727,7 @@ static const struct iio_info mpu_info = {
> /**
> * inv_check_and_setup_chip() - check and setup chip.
> */
> -static int inv_check_and_setup_chip(struct inv_mpu6050_state *st,
> - const struct i2c_device_id *id)
> +static int inv_check_and_setup_chip(struct inv_mpu6050_state *st)
> {
> int result;
>
> @@ -795,7 +794,7 @@ static int inv_mpu_probe(struct i2c_client *client,
> if (pdata)
> st->plat_data = *pdata;
> /* power is turned on inside check chip type*/
> - result = inv_check_and_setup_chip(st, id);
> + result = inv_check_and_setup_chip(st);
> if (result)
> return result;
>
>
next prev parent reply other threads:[~2016-01-30 17:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-30 9:43 [RFC PATCH 0/5] iio: imu: inv_mpu6050: Split driver into core and I2C/SPI functionality Adriana Reus
2016-01-30 9:43 ` [PATCH 1/5] iio: imu: inv-mpu6050: Fix interrupt pin configuration Adriana Reus
2016-01-30 17:16 ` Jonathan Cameron
2016-01-30 9:43 ` [PATCH 2/5] iio: inv_mpu6050: Remove unused parameter Adriana Reus
2016-01-30 17:18 ` Jonathan Cameron [this message]
2016-01-30 9:43 ` [RFC PATCH 3/5] iio: imu: inv_mpu6050: Use regmap instead of i2c specific functions Adriana Reus
2016-01-30 17:21 ` Jonathan Cameron
2016-01-30 9:43 ` [RFC PATCH 4/5] iio: imu: inv_mpu6050: Separate driver into core and i2c functionality Adriana Reus
2016-01-30 17:37 ` Jonathan Cameron
2016-01-30 9:43 ` [RFC PATCH 5/5] iio: imu: inv_mpu6050: Add SPI support for MPU6000 Adriana Reus
2016-01-30 17:48 ` Jonathan Cameron
2016-01-30 17:11 ` [RFC PATCH 0/5] iio: imu: inv_mpu6050: Split driver into core and I2C/SPI functionality Jonathan Cameron
2016-02-01 9:01 ` Adriana Reus
2016-02-02 1:11 ` Ge Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56ACF053.2050807@kernel.org \
--to=jic23@kernel.org \
--cc=adriana.reus@intel.com \
--cc=ggao@invensense.com \
--cc=linux-iio@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).