From: Jonathan Cameron <jic23@kernel.org>
To: Daniel Baluta <daniel.baluta@intel.com>,
Lucas De Marchi <lucas.de.marchi@gmail.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
lkml <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Michael Welling <mwelling@ieee.org>,
Guenter Roeck <linux@roeck-us.net>,
eibach@gdsys.de
Subject: Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support
Date: Sat, 6 Feb 2016 10:52:07 +0000 [thread overview]
Message-ID: <56B5D057.2090208@kernel.org> (raw)
In-Reply-To: <CAEnQRZD6n5ZdgPGA7pD6_Od_FwP=hn5mKcA5WJ3daUGuJBcSvw@mail.gmail.com>
On 05/02/16 21:44, Daniel Baluta wrote:
> On Fri, Feb 5, 2016 at 11:02 PM, Lucas De Marchi
> <lucas.de.marchi@gmail.com> wrote:
>> Hi Daniel,
>>
>> On Fri, Feb 5, 2016 at 11:17 AM, Daniel Baluta <daniel.baluta@intel.com> wrote:
>>> +
>>> +static const struct i2c_device_id ads1015_id[] = {
>>> + {"ads1015", 0},
>>> + {}
>>> +};
>>
>> Since this module is not 100% compatible with the hwmon version,
>> wouldn't it be better to use another id?
>
> Hmm, as it is now it should be 100% compatible with the hwmon driver
> for ads1015 device.
>
> I don't have a strong preference for id here. Do you see any problems using
> this id?
We definitely want to keep the ID if at all possible as otherwise
we end up with a driver choice having to be made at compile time (or possibly
via the device tree). If there is a compatibility issue, then Lucas,
please highlight it.
In the short term both drivers will exist and we'll rely on the Kconfig tricks
above to prevent them being both built. Longer term, if this driver supports
all features of the HWMON driver (via the iio-hwmon bridge) then then extra
support in here will make it sensible to drop the HWMON driver (just not for
at least a cycle or two I would guess).
Jonathan
>
>>
>> Other than that, I tested it on the MinnowBoard Max with a Drone Lure
>> connected and it works fine.
>
> thanks,
> Daniel.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-02-06 10:52 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 13:17 [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Daniel Baluta
2016-02-05 17:25 ` Michael Welling
2016-02-05 19:32 ` Daniel Baluta
2016-02-05 19:50 ` Michael Welling
2016-02-06 0:32 ` Michael Welling
2016-02-08 10:25 ` Wolfram Sang
2016-02-08 14:44 ` Daniel Baluta
2016-02-08 15:03 ` Daniel Baluta
2016-02-08 16:37 ` Michael Welling
2016-02-08 16:36 ` Michael Welling
2016-02-08 19:11 ` Sricharan
2016-02-08 19:16 ` Michael Welling
2016-02-08 20:00 ` Wolfram Sang
2016-02-08 20:06 ` Michael Welling
2016-02-10 12:22 ` Sricharan
2016-02-10 12:56 ` Daniel Baluta
2016-02-10 15:09 ` Sricharan
2016-02-10 16:36 ` Michael Welling
2016-02-17 23:53 ` Michael Welling
2016-02-18 8:45 ` Sricharan
2016-02-05 21:02 ` Lucas De Marchi
2016-02-05 21:44 ` Daniel Baluta
2016-02-06 10:52 ` Jonathan Cameron [this message]
2016-02-06 11:05 ` Jonathan Cameron
2016-02-06 11:07 ` Jonathan Cameron
2016-03-01 0:50 ` Michael Welling
2016-03-01 1:09 ` Lucas De Marchi
2016-03-01 1:16 ` Michael Welling
2016-03-01 1:33 ` Michael Welling
2016-03-01 2:42 ` Michael Welling
2016-03-01 8:35 ` jic23
2016-03-01 16:02 ` Michael Welling
2016-03-01 17:24 ` Jonathan Cameron
2016-03-01 11:28 ` Daniel Baluta
2016-03-01 15:57 ` Michael Welling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B5D057.2090208@kernel.org \
--to=jic23@kernel.org \
--cc=daniel.baluta@intel.com \
--cc=eibach@gdsys.de \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lucas.de.marchi@gmail.com \
--cc=lucas.demarchi@intel.com \
--cc=mwelling@ieee.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).