* [PATCH] iio: chemical: select IRQ_WORK for ATLAS ph sensor
@ 2016-02-02 14:36 Arnd Bergmann
2016-02-03 7:55 ` Matt Ranostay
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2016-02-02 14:36 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linux-iio, linux-kernel, Matt Ranostay, Peter Meerwald,
Lars-Peter Clausen, Hartmut Knaack, linux-arm-kernel
The newly added atlas-ph-sensor driver uses irq_work_queue, which
may not always be enabled:
ERROR: "irq_work_queue" [drivers/iio/chemical/atlas-ph-sensor.ko] undefined!
This adds a 'select' statement to Kconfig to ensure it's there
when we need it.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 27dec00ecf2d ("iio: chemical: add Atlas pH-SM sensor support")
diff --git a/drivers/iio/chemical/Kconfig b/drivers/iio/chemical/Kconfig
index ce7cd1370f74..f73290f84c90 100644
--- a/drivers/iio/chemical/Kconfig
+++ b/drivers/iio/chemical/Kconfig
@@ -10,6 +10,7 @@ config ATLAS_PH_SENSOR
select REGMAP_I2C
select IIO_BUFFER
select IIO_TRIGGERED_BUFFER
+ select IRQ_WORK
help
Say Y here to build I2C interface support for the Atlas
Scientific OEM pH-SM sensor.
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iio: chemical: select IRQ_WORK for ATLAS ph sensor
2016-02-02 14:36 [PATCH] iio: chemical: select IRQ_WORK for ATLAS ph sensor Arnd Bergmann
@ 2016-02-03 7:55 ` Matt Ranostay
2016-02-06 18:38 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Matt Ranostay @ 2016-02-03 7:55 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jonathan Cameron, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, Peter Meerwald, Lars-Peter Clausen,
Hartmut Knaack, Linux ARM Kernel List
Reviewed-by: Matt Ranostay <mranostay@gmail.com>
On Tue, Feb 2, 2016 at 6:36 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The newly added atlas-ph-sensor driver uses irq_work_queue, which
> may not always be enabled:
>
> ERROR: "irq_work_queue" [drivers/iio/chemical/atlas-ph-sensor.ko] undefined!
>
> This adds a 'select' statement to Kconfig to ensure it's there
> when we need it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 27dec00ecf2d ("iio: chemical: add Atlas pH-SM sensor support")
>
> diff --git a/drivers/iio/chemical/Kconfig b/drivers/iio/chemical/Kconfig
> index ce7cd1370f74..f73290f84c90 100644
> --- a/drivers/iio/chemical/Kconfig
> +++ b/drivers/iio/chemical/Kconfig
> @@ -10,6 +10,7 @@ config ATLAS_PH_SENSOR
> select REGMAP_I2C
> select IIO_BUFFER
> select IIO_TRIGGERED_BUFFER
> + select IRQ_WORK
> help
> Say Y here to build I2C interface support for the Atlas
> Scientific OEM pH-SM sensor.
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iio: chemical: select IRQ_WORK for ATLAS ph sensor
2016-02-03 7:55 ` Matt Ranostay
@ 2016-02-06 18:38 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2016-02-06 18:38 UTC (permalink / raw)
To: Matt Ranostay, Arnd Bergmann
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Peter Meerwald, Lars-Peter Clausen, Hartmut Knaack,
Linux ARM Kernel List
On 03/02/16 07:55, Matt Ranostay wrote:
> Reviewed-by: Matt Ranostay <mranostay@gmail.com>
>
> On Tue, Feb 2, 2016 at 6:36 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> The newly added atlas-ph-sensor driver uses irq_work_queue, which
>> may not always be enabled:
>>
>> ERROR: "irq_work_queue" [drivers/iio/chemical/atlas-ph-sensor.ko] undefined!
>>
>> This adds a 'select' statement to Kconfig to ensure it's there
>> when we need it.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: 27dec00ecf2d ("iio: chemical: add Atlas pH-SM sensor support")
>>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to fail to spot and IRQ_WORK related issues ;)
Thanks,
Jonathan
>> diff --git a/drivers/iio/chemical/Kconfig b/drivers/iio/chemical/Kconfig
>> index ce7cd1370f74..f73290f84c90 100644
>> --- a/drivers/iio/chemical/Kconfig
>> +++ b/drivers/iio/chemical/Kconfig
>> @@ -10,6 +10,7 @@ config ATLAS_PH_SENSOR
>> select REGMAP_I2C
>> select IIO_BUFFER
>> select IIO_TRIGGERED_BUFFER
>> + select IRQ_WORK
>> help
>> Say Y here to build I2C interface support for the Atlas
>> Scientific OEM pH-SM sensor.
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-06 18:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-02 14:36 [PATCH] iio: chemical: select IRQ_WORK for ATLAS ph sensor Arnd Bergmann
2016-02-03 7:55 ` Matt Ranostay
2016-02-06 18:38 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).