[PATCH 2/2] drivers: iio: adc: xilinx-xadc-events: Fixed a coding style warning.

[PATCH 2/2] drivers: iio: adc: xilinx-xadc-events: Fixed a coding style warning.

[Rakhi Sharma]

Fixed a warning.
WARNING: else is not generally useful after a break or return

Signed-off-by: Rakhi Sharma <rakhish1994@gmail.com>
---
 drivers/iio/adc/xilinx-xadc-events.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/xilinx-xadc-events.c b/drivers/iio/adc/xilinx-xadc-events.c
index edcf3aa..61309b3 100644
--- a/drivers/iio/adc/xilinx-xadc-events.c
+++ b/drivers/iio/adc/xilinx-xadc-events.c
@@ -92,7 +92,7 @@ static unsigned int xadc_get_alarm_mask(const struct iio_chan_spec *chan)
 {
 	if (chan->type == IIO_TEMP) {
 		return XADC_ALARM_OT_MASK;
-	} else {
+	}
 		switch (chan->channel) {
 		case 0:
 			return XADC_ALARM_VCCINT_MASK;
-- 
1.9.1

Re: [PATCH 2/2] drivers: iio: adc: xilinx-xadc-events: Fixed a coding style warning.

[Jonathan Cameron]

On 06/02/16 20:00, Rakhi Sharma wrote:
> Fixed a warning.
> WARNING: else is not generally useful after a break or return
> 
> Signed-off-by: Rakhi Sharma <rakhish1994@gmail.com>
A worthwhile aim, though sometimes such an else statement can reflect
a 'balance' in the code acting as a simple two element case statement.

However...
Please think through the results of your patches.  You've just removed
and open bracket without finding and removing the close bracket.
Also an open bracket removal means that the code indentation of the next
block is now wrong.

So, please revisit this patch, but next time make sure to at compile
test it before posting the patch - you would have had both errors
and warnings about the indenting from the result of this patch.

Jonathan
> ---
>  drivers/iio/adc/xilinx-xadc-events.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/xilinx-xadc-events.c b/drivers/iio/adc/xilinx-xadc-events.c
> index edcf3aa..61309b3 100644
> --- a/drivers/iio/adc/xilinx-xadc-events.c
> +++ b/drivers/iio/adc/xilinx-xadc-events.c
> @@ -92,7 +92,7 @@ static unsigned int xadc_get_alarm_mask(const struct iio_chan_spec *chan)
>  {
>  	if (chan->type == IIO_TEMP) {
>  		return XADC_ALARM_OT_MASK;
> -	} else {
> +	}
>  		switch (chan->channel) {
>  		case 0:
>  			return XADC_ALARM_VCCINT_MASK;
>