From: Jonathan Cameron <jic23@kernel.org>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: Fix documentation for iio_dev mlock
Date: Mon, 8 Feb 2016 18:34:50 +0000 [thread overview]
Message-ID: <56B8DFCA.9010807@kernel.org> (raw)
In-Reply-To: <1454943795-7582-1-git-send-email-daniel.baluta@intel.com>
On 08/02/16 15:03, Daniel Baluta wrote:
> mlock *must* be used by core and drivers to protect access
> to devices state changes.
>
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Applied. Thanks for cleaning this up.
Jonathan
> ---
> At a first glance there are few places where access to iio_dev
> state changes are done without mlock protection. Will fix them
> with follow up patches.
>
> include/linux/iio/iio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index b589411..ce9e9c1 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -448,7 +448,7 @@ struct iio_buffer_setup_ops {
> * @buffer: [DRIVER] any buffer present
> * @buffer_list: [INTERN] list of all buffers currently attached
> * @scan_bytes: [INTERN] num bytes captured to be fed to buffer demux
> - * @mlock: [INTERN] lock used to prevent simultaneous device state
> + * @mlock: [DRIVER] lock used to prevent simultaneous device state
> * changes
> * @available_scan_masks: [DRIVER] optional array of allowed bitmasks
> * @masklength: [INTERN] the length of the mask established from
>
prev parent reply other threads:[~2016-02-08 18:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 15:03 [PATCH] iio: Fix documentation for iio_dev mlock Daniel Baluta
2016-02-08 18:34 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B8DFCA.9010807@kernel.org \
--to=jic23@kernel.org \
--cc=daniel.baluta@intel.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).