From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@kernel.org>,
Adriana Reus <adriana.reus@intel.com>
Cc: linux-iio@vger.kernel.org, srinivas.pandruvada@linux.intel.com,
ggao@invensense.com, daniel.baluta@intel.com, mwelling@ieee.org,
lucas.de.marchi@gmail.com, adi.reus@gmail.com
Subject: Re: [PATCH v3 0/4] iio: imu: inv_mpu6050: Split driver into core and I2C/SPI functionality
Date: Tue, 9 Feb 2016 21:47:52 +0100 [thread overview]
Message-ID: <56BA5078.9090307@metafoo.de> (raw)
In-Reply-To: <56BA4F97.40002@kernel.org>
On 02/09/2016 09:44 PM, Jonathan Cameron wrote:
> On 09/02/16 15:38, Adriana Reus wrote:
>> This series splits this driver into general and I2C/SPI specific functionality.
>> The first patch is a fix for a bug in the interrupt pin configuration.
>> The second patch changes all the I2C specific calls into regmap calls.
>> The third patch separated the remaining I2C specific part into a different component.
>> Finally the fourth patch adds SPI support for the MPU6000 chip.
>>
>> No changes since v2 for the first two patches.
>> Adressed comments for the last two patches
>>
>> Adriana Reus (4):
>> iio: imu: inv-mpu6050: Fix interrupt pin configuration
>> iio: imu: inv_mpu6050: Use regmap instead of i2c specific functions
>> iio: imu: inv_mpu6050: Separate driver into core and i2c
>> functionality.
>> iio: imu: inv_mpu6050: Add SPI support for MPU6000
>>
>> drivers/iio/imu/inv_mpu6050/Kconfig | 21 ++-
>> drivers/iio/imu/inv_mpu6050/Makefile | 8 +-
>> drivers/iio/imu/inv_mpu6050/inv_mpu_acpi.c | 18 +-
>> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 258 ++++++--------------------
>> drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c | 207 +++++++++++++++++++++
>> drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 19 +-
>> drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c | 35 ++--
>> drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c | 106 +++++++++++
>> drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c | 10 +-
>> 9 files changed, 440 insertions(+), 242 deletions(-)
>> create mode 100644 drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c
>> create mode 100644 drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c
>>
> Just to make sure you don't miss it, (and for my reference as I
> might forget those emails before I apply this)
> there are some additional comments on V2 from Lars that crossed
> with V3 that need addressing.
Oh, sorry, I though I was replying to v3, but yeah, same issues still in v3.
prev parent reply other threads:[~2016-02-09 21:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 15:38 [PATCH v3 0/4] iio: imu: inv_mpu6050: Split driver into core and I2C/SPI functionality Adriana Reus
2016-02-09 15:38 ` [PATCH v3 1/4] iio: imu: inv-mpu6050: Fix interrupt pin configuration Adriana Reus
2016-02-09 15:38 ` [PATCH v3 2/4] iio: imu: inv_mpu6050: Use regmap instead of i2c specific functions Adriana Reus
2016-02-10 9:57 ` Crt Mori
2016-02-09 15:38 ` [PATCH v3 3/4] iio: imu: inv_mpu6050: Separate driver into core and i2c functionality Adriana Reus
2016-02-09 15:38 ` [PATCH v3 4/4] iio: imu: inv_mpu6050: Add SPI support for MPU6000 Adriana Reus
2016-02-09 16:28 ` [PATCH v3 0/4] iio: imu: inv_mpu6050: Split driver into core and I2C/SPI functionality Michael Welling
2016-02-09 20:44 ` Jonathan Cameron
2016-02-09 20:47 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BA5078.9090307@metafoo.de \
--to=lars@metafoo.de \
--cc=adi.reus@gmail.com \
--cc=adriana.reus@intel.com \
--cc=daniel.baluta@intel.com \
--cc=ggao@invensense.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=mwelling@ieee.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).