linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Cristina Moraru <cristina.moraru09@gmail.com>,
	knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
	gregkh@linuxfoundation.org, cristina.opriceana@gmail.com,
	marek@goldelico.com, sdliyong@gmail.com,
	linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
	tolga.ceylan@gmail.com, k.kozlowski@samsung.com,
	javier@osg.samsung.com, arnd@arndb.de, geert@linux-m68k.org,
	irina.tirdea@intel.com, daniel.baluta@intel.com,
	octavia.purdila@intel.com
Subject: Re: [PATCH 4/5] iio: hmc5843: Fix comment style warnings
Date: Tue, 9 Feb 2016 22:17:01 +0000	[thread overview]
Message-ID: <56BA655D.4000407@kernel.org> (raw)
In-Reply-To: <1454883711-15489-5-git-send-email-cristina.moraru09@gmail.com>

On 07/02/16 22:21, Cristina Moraru wrote:
> Fix comment style warnings in order to comply with Coding Style
> standard provided by Documentation/CodingStyle.
> 
> This patch solves following issue found with checkpatch:
> WARNING: Block comments use a trailing */ on a separate line
> 
> Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
I've applied this, but with a few additions... see inline.
> ---
>  drivers/staging/iio/magnetometer/hmc5843.h     | 4 ++--
>  drivers/staging/iio/magnetometer/hmc5843_i2c.c | 2 +-
>  drivers/staging/iio/magnetometer/hmc5843_spi.c | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/iio/magnetometer/hmc5843.h b/drivers/staging/iio/magnetometer/hmc5843.h
> index 06f35d3..cb284cf 100644
> --- a/drivers/staging/iio/magnetometer/hmc5843.h
> +++ b/drivers/staging/iio/magnetometer/hmc5843.h
> @@ -8,7 +8,7 @@
>   * it under the terms of the GNU General Public License version 2 as
>   * published by the Free Software Foundation.
>   *
Dropped the unwanted empty comment line as it doesn't add anything and we
might as well clean it up whilst here.
> - * */
> + */
>  
>  #ifndef HMC5843_CORE_H
>  #define HMC5843_CORE_H
> @@ -38,7 +38,7 @@ enum hmc5843_ids {
>   * @regmap:		hardware access register maps
>   * @variant:		describe chip variants
>   * @buffer:		3x 16-bit channels + padding + 64-bit timestamp
> - **/
> + */
>  struct hmc5843_data {
>  	struct device *dev;
>  	struct mutex lock;
> diff --git a/drivers/staging/iio/magnetometer/hmc5843_i2c.c b/drivers/staging/iio/magnetometer/hmc5843_i2c.c
> index 3e06ceb..6f7b8fb 100644
> --- a/drivers/staging/iio/magnetometer/hmc5843_i2c.c
> +++ b/drivers/staging/iio/magnetometer/hmc5843_i2c.c
> @@ -8,7 +8,7 @@
>   * it under the terms of the GNU General Public License version 2 as
>   * published by the Free Software Foundation.
>   *
snap
> - * */
> + */
>  
>  #include <linux/module.h>
>  #include <linux/i2c.h>
> diff --git a/drivers/staging/iio/magnetometer/hmc5843_spi.c b/drivers/staging/iio/magnetometer/hmc5843_spi.c
> index 1549192..85adcdd 100644
> --- a/drivers/staging/iio/magnetometer/hmc5843_spi.c
> +++ b/drivers/staging/iio/magnetometer/hmc5843_spi.c
> @@ -7,7 +7,7 @@
>   * it under the terms of the GNU General Public License version 2 as
>   * published by the Free Software Foundation.
>   *
snap.
> - * */
> + */
>  
>  #include <linux/module.h>
>  #include <linux/spi/spi.h>
> 


  reply	other threads:[~2016-02-09 22:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-07 22:21 [PATCH 0/5] iio: hmc5843: Fix issues and move out of staging Cristina Moraru
2016-02-07 22:21 ` [PATCH 1/5] iio: hmc5843: Add attribute for available measurement config Cristina Moraru
2016-02-09 22:10   ` Jonathan Cameron
2016-02-07 22:21 ` [PATCH 2/5] iio: hmc5843: Swap suspend and resume implementations Cristina Moraru
2016-02-09 22:14   ` Jonathan Cameron
2016-02-07 22:21 ` [PATCH 3/5] iio: hmc5843: Add ABI documentation file for hmc5843 Cristina Moraru
2016-02-07 22:21 ` [PATCH 4/5] iio: hmc5843: Fix comment style warnings Cristina Moraru
2016-02-09 22:17   ` Jonathan Cameron [this message]
2016-02-07 22:21 ` [PATCH 5/5] iio: hmc5843: Move hmc5843 out of staging Cristina Moraru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56BA655D.4000407@kernel.org \
    --to=jic23@kernel.org \
    --cc=arnd@arndb.de \
    --cc=cristina.moraru09@gmail.com \
    --cc=cristina.opriceana@gmail.com \
    --cc=daniel.baluta@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=irina.tirdea@intel.com \
    --cc=javier@osg.samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marek@goldelico.com \
    --cc=octavia.purdila@intel.com \
    --cc=pmeerw@pmeerw.net \
    --cc=sdliyong@gmail.com \
    --cc=tolga.ceylan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).