From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:55962 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964895AbcBQTcL (ORCPT ); Wed, 17 Feb 2016 14:32:11 -0500 Subject: Re: [PATCH] iio: health/afe4403: select REGMAP_SPI To: "Andrew F. Davis" , Arnd Bergmann References: <1455637959-3169264-1-git-send-email-arnd@arndb.de> <56C34AF8.7080104@ti.com> Cc: linux-arm-kernel@lists.infradead.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Matt Ranostay , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org From: Jonathan Cameron Message-ID: <56C4CAB9.8000609@kernel.org> Date: Wed, 17 Feb 2016 19:32:09 +0000 MIME-Version: 1.0 In-Reply-To: <56C34AF8.7080104@ti.com> Content-Type: text/plain; charset=windows-1252 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 16/02/16 16:14, Andrew F. Davis wrote: > On 02/16/2016 09:52 AM, Arnd Bergmann wrote: >> The newly added afe4403 driver uses the regmap facility to abstract >> the I2C and SPI access. However, it fails to ensure that regmap_spi >> is actually present: >> >> drivers/iio/built-in.o: In function `afe4403_probe': >> :(.text+0x9bf8): undefined reference to `__devm_regmap_init_spi' >> >> This adds a Kconfig select statement like the afe4404 I2C driver >> has. >> >> Signed-off-by: Arnd Bergmann >> Fixes: eec96d1e2d31 ("iio: health: Add driver for the TI AFE4403 heart monitor") >> --- >> drivers/iio/health/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/iio/health/Kconfig b/drivers/iio/health/Kconfig >> index f0c19779ac27..c5f004a8e447 100644 >> --- a/drivers/iio/health/Kconfig >> +++ b/drivers/iio/health/Kconfig >> @@ -10,6 +10,7 @@ menu "Heart Rate Monitors" >> config AFE4403 >> tristate "TI AFE4403 Heart Rate Monitor" >> depends on SPI_MASTER >> + select REGMAP_SPI >> select IIO_BUFFER >> select IIO_TRIGGERED_BUFFER >> help >> > > Oversight on my part, thanks for fix. > > Acked-by: Andrew F. Davis Applied to the togreg branch of iio.git - initially pushed out as testing for the autobuilders to fail to trigger similar issues... (ah well, they can't hammer everything!) Thanks Arnd! Jonathan