Re: [PATCH v3 4/6] iio:pressure:ms5611: DT bindings documentation

[Jonathan Cameron <jic23@kernel.org>]

On 17/02/16 17:52, Gregor Boirie wrote:
> From: Grégor Boirie <gregor.boirie@parrot.com>
> 
> Signed-off-by: Gregor Boirie <gregor.boirie@parrot.com>
One comment inline - though a quick look shows this idiom is common
which isn't great.

Also ideal would be to add the device_tree id tables and have the
documented binding include the manufacturer prefix.
> ---
>  .../devicetree/bindings/iio/pressure/ms5611.txt       | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/pressure/ms5611.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/pressure/ms5611.txt b/Documentation/devicetree/bindings/iio/pressure/ms5611.txt
> new file mode 100644
> index 0000000..986415a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/pressure/ms5611.txt
> @@ -0,0 +1,19 @@
> +MEAS ms5611 family pressure sensors
> +
> +Pressure sensors from MEAS Switzerland with SPI and I2C bus interfaces.
> +
> +Required properties:
> +- compatible: "ms5611" or "ms5607"
Preferred to be prefixed with the manufacturer though that requires adding
tables to the various drivers.  Ideally please do so and update this to include those
values as the preferred choices.


> +- reg: the I2C or SPI address the device will respond to
SPI buses don't have an address (they do have a chip select though).

> +
> +Optional properties:
> +- vdd-supply: an optional regulator that needs to be on to provide VDD
> +  power to the sensor.
> +
> +Example:
> +
> +ms5607@77 {
> +	compatible = "ms5607";
> +	reg = <0x77>;
> +	vdd-supply = <&ldo_3v3_gnss>;
> +};
>