From: Jonathan Cameron <jic23@kernel.org>
To: David Wu <david.wu@rock-chips.com>, heiko@sntech.de
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
huangtao@rock-chips.com, xjq@rock-chips.com, zyw@rock-chips.com,
cf@rock-chips.com, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: rockchip_saradc: add saradc support for rk3399
Date: Wed, 16 Mar 2016 20:51:34 +0000 [thread overview]
Message-ID: <56E9C756.10104@kernel.org> (raw)
In-Reply-To: <1458063855-4154-1-git-send-email-david.wu@rock-chips.com>
On 15/03/16 17:44, David Wu wrote:
> The ADC is a 6-channel signal-ended 10-bit Successive
> Approximation Register (SAR) A/D Converter.
>
> Signed-off-by: David Wu <david.wu@rock-chips.com>
Looks straight forward so applied to the togreg branch of iio.git,
pushed out as testing for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> .../devicetree/bindings/iio/adc/rockchip-saradc.txt | 6 +++++-
> drivers/iio/adc/rockchip_saradc.c | 19 +++++++++++++++++++
> 2 files changed, 24 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt
> index a9a5fe1..bf99e2f 100644
> --- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt
> @@ -1,7 +1,11 @@
> Rockchip Successive Approximation Register (SAR) A/D Converter bindings
>
> Required properties:
> -- compatible: Should be "rockchip,saradc" or "rockchip,rk3066-tsadc"
> +- compatible: should be "rockchip,<name>-saradc" or "rockchip,rk3066-tsadc"
> + - "rockchip,saradc": for rk3188, rk3288
> + - "rockchip,rk3066-tsadc": for rk3036
> + - "rockchip,rk3399-saradc": for rk3399
> +
> - reg: physical base address of the controller and length of memory mapped
> region.
> - interrupts: The interrupt number to the cpu. The interrupt specifier format
> diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
> index 9c311c1..f9ad6c2 100644
> --- a/drivers/iio/adc/rockchip_saradc.c
> +++ b/drivers/iio/adc/rockchip_saradc.c
> @@ -159,6 +159,22 @@ static const struct rockchip_saradc_data rk3066_tsadc_data = {
> .clk_rate = 50000,
> };
>
> +static const struct iio_chan_spec rockchip_rk3399_saradc_iio_channels[] = {
> + ADC_CHANNEL(0, "adc0"),
> + ADC_CHANNEL(1, "adc1"),
> + ADC_CHANNEL(2, "adc2"),
> + ADC_CHANNEL(3, "adc3"),
> + ADC_CHANNEL(4, "adc4"),
> + ADC_CHANNEL(5, "adc5"),
> +};
> +
> +static const struct rockchip_saradc_data rk3399_saradc_data = {
> + .num_bits = 10,
> + .channels = rockchip_rk3399_saradc_iio_channels,
> + .num_channels = ARRAY_SIZE(rockchip_rk3399_saradc_iio_channels),
> + .clk_rate = 1000000,
> +};
> +
> static const struct of_device_id rockchip_saradc_match[] = {
> {
> .compatible = "rockchip,saradc",
> @@ -166,6 +182,9 @@ static const struct of_device_id rockchip_saradc_match[] = {
> }, {
> .compatible = "rockchip,rk3066-tsadc",
> .data = &rk3066_tsadc_data,
> + }, {
> + .compatible = "rockchip,rk3399-saradc",
> + .data = &rk3399_saradc_data,
> },
> {},
> };
>
prev parent reply other threads:[~2016-03-16 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 17:44 [PATCH] iio: adc: rockchip_saradc: add saradc support for rk3399 David Wu
2016-03-16 20:51 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E9C756.10104@kernel.org \
--to=jic23@kernel.org \
--cc=cf@rock-chips.com \
--cc=david.wu@rock-chips.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pmeerw@pmeerw.net \
--cc=xjq@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).