From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] iio: adc: Fix build error of missing devm_ioremap_resource on UM
Date: Mon, 28 Mar 2016 09:45:39 +0100 [thread overview]
Message-ID: <56F8EF33.2090709@kernel.org> (raw)
In-Reply-To: <56DB2A37.8040708@kernel.org>
On 05/03/16 18:49, Jonathan Cameron wrote:
> On 04/03/16 01:05, Krzysztof Kozlowski wrote:
>> The devres.o gets linked if HAS_IOMEM is present so on ARCH=um
>> allyesconfig (COMPILE_TEST) failed with:
>>
>> drivers/built-in.o: In function `at91_adc_probe':
>> at91-sama5d2_adc.c:(.text+0x48f548): undefined reference to `devm_ioremap_resource'
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Applied to the togreg branch of iio.git - initially pushed out as testing for
> the autobuilders to play with it. I may switch this over to a fixes branch
> and send it on post merge window (if the merge window starts before my next
> pull request).
This did indeed miss, so I'll pull it across to the fixes branch once the merge window
closes.
Jonathan
>
> Jonathan
>> ---
>> drivers/iio/adc/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
>> index af4aea7b20f9..82c718c515a0 100644
>> --- a/drivers/iio/adc/Kconfig
>> +++ b/drivers/iio/adc/Kconfig
>> @@ -134,6 +134,7 @@ config AT91_ADC
>> config AT91_SAMA5D2_ADC
>> tristate "Atmel AT91 SAMA5D2 ADC"
>> depends on ARCH_AT91 || COMPILE_TEST
>> + depends on HAS_IOMEM
>> help
>> Say yes here to build support for Atmel SAMA5D2 ADC which is
>> available on SAMA5D2 SoC family.
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2016-03-28 8:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 1:05 [PATCH] iio: adc: Fix build error of missing devm_ioremap_resource on UM Krzysztof Kozlowski
2016-03-05 18:49 ` Jonathan Cameron
2016-03-28 8:45 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F8EF33.2090709@kernel.org \
--to=jic23@kernel.org \
--cc=arnd@arndb.de \
--cc=k.kozlowski@samsung.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).