From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:44128 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754654AbcC1Ipm (ORCPT ); Mon, 28 Mar 2016 04:45:42 -0400 Subject: Re: [PATCH] iio: adc: Fix build error of missing devm_ioremap_resource on UM To: Krzysztof Kozlowski , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <1457053526-28841-1-git-send-email-k.kozlowski@samsung.com> <56DB2A37.8040708@kernel.org> Cc: Arnd Bergmann From: Jonathan Cameron Message-ID: <56F8EF33.2090709@kernel.org> Date: Mon, 28 Mar 2016 09:45:39 +0100 MIME-Version: 1.0 In-Reply-To: <56DB2A37.8040708@kernel.org> Content-Type: text/plain; charset=windows-1252 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 05/03/16 18:49, Jonathan Cameron wrote: > On 04/03/16 01:05, Krzysztof Kozlowski wrote: >> The devres.o gets linked if HAS_IOMEM is present so on ARCH=um >> allyesconfig (COMPILE_TEST) failed with: >> >> drivers/built-in.o: In function `at91_adc_probe': >> at91-sama5d2_adc.c:(.text+0x48f548): undefined reference to `devm_ioremap_resource' >> >> Signed-off-by: Krzysztof Kozlowski > Applied to the togreg branch of iio.git - initially pushed out as testing for > the autobuilders to play with it. I may switch this over to a fixes branch > and send it on post merge window (if the merge window starts before my next > pull request). This did indeed miss, so I'll pull it across to the fixes branch once the merge window closes. Jonathan > > Jonathan >> --- >> drivers/iio/adc/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig >> index af4aea7b20f9..82c718c515a0 100644 >> --- a/drivers/iio/adc/Kconfig >> +++ b/drivers/iio/adc/Kconfig >> @@ -134,6 +134,7 @@ config AT91_ADC >> config AT91_SAMA5D2_ADC >> tristate "Atmel AT91 SAMA5D2 ADC" >> depends on ARCH_AT91 || COMPILE_TEST >> + depends on HAS_IOMEM >> help >> Say yes here to build support for Atmel SAMA5D2 ADC which is >> available on SAMA5D2 SoC family. >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >