* [PATCH] iio: adc: Fix build error of missing devm_ioremap_resource on UM
@ 2016-03-04 1:05 Krzysztof Kozlowski
2016-03-05 18:49 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2016-03-04 1:05 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald, linux-iio, linux-kernel
Cc: Arnd Bergmann, Krzysztof Kozlowski
The devres.o gets linked if HAS_IOMEM is present so on ARCH=um
allyesconfig (COMPILE_TEST) failed with:
drivers/built-in.o: In function `at91_adc_probe':
at91-sama5d2_adc.c:(.text+0x48f548): undefined reference to `devm_ioremap_resource'
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
drivers/iio/adc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index af4aea7b20f9..82c718c515a0 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -134,6 +134,7 @@ config AT91_ADC
config AT91_SAMA5D2_ADC
tristate "Atmel AT91 SAMA5D2 ADC"
depends on ARCH_AT91 || COMPILE_TEST
+ depends on HAS_IOMEM
help
Say yes here to build support for Atmel SAMA5D2 ADC which is
available on SAMA5D2 SoC family.
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: Fix build error of missing devm_ioremap_resource on UM
2016-03-04 1:05 [PATCH] iio: adc: Fix build error of missing devm_ioremap_resource on UM Krzysztof Kozlowski
@ 2016-03-05 18:49 ` Jonathan Cameron
2016-03-28 8:45 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2016-03-05 18:49 UTC (permalink / raw)
To: Krzysztof Kozlowski, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald, linux-iio, linux-kernel
Cc: Arnd Bergmann
On 04/03/16 01:05, Krzysztof Kozlowski wrote:
> The devres.o gets linked if HAS_IOMEM is present so on ARCH=um
> allyesconfig (COMPILE_TEST) failed with:
>
> drivers/built-in.o: In function `at91_adc_probe':
> at91-sama5d2_adc.c:(.text+0x48f548): undefined reference to `devm_ioremap_resource'
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Applied to the togreg branch of iio.git - initially pushed out as testing for
the autobuilders to play with it. I may switch this over to a fixes branch
and send it on post merge window (if the merge window starts before my next
pull request).
Jonathan
> ---
> drivers/iio/adc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index af4aea7b20f9..82c718c515a0 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -134,6 +134,7 @@ config AT91_ADC
> config AT91_SAMA5D2_ADC
> tristate "Atmel AT91 SAMA5D2 ADC"
> depends on ARCH_AT91 || COMPILE_TEST
> + depends on HAS_IOMEM
> help
> Say yes here to build support for Atmel SAMA5D2 ADC which is
> available on SAMA5D2 SoC family.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: Fix build error of missing devm_ioremap_resource on UM
2016-03-05 18:49 ` Jonathan Cameron
@ 2016-03-28 8:45 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2016-03-28 8:45 UTC (permalink / raw)
To: Krzysztof Kozlowski, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald, linux-iio, linux-kernel
Cc: Arnd Bergmann
On 05/03/16 18:49, Jonathan Cameron wrote:
> On 04/03/16 01:05, Krzysztof Kozlowski wrote:
>> The devres.o gets linked if HAS_IOMEM is present so on ARCH=um
>> allyesconfig (COMPILE_TEST) failed with:
>>
>> drivers/built-in.o: In function `at91_adc_probe':
>> at91-sama5d2_adc.c:(.text+0x48f548): undefined reference to `devm_ioremap_resource'
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Applied to the togreg branch of iio.git - initially pushed out as testing for
> the autobuilders to play with it. I may switch this over to a fixes branch
> and send it on post merge window (if the merge window starts before my next
> pull request).
This did indeed miss, so I'll pull it across to the fixes branch once the merge window
closes.
Jonathan
>
> Jonathan
>> ---
>> drivers/iio/adc/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
>> index af4aea7b20f9..82c718c515a0 100644
>> --- a/drivers/iio/adc/Kconfig
>> +++ b/drivers/iio/adc/Kconfig
>> @@ -134,6 +134,7 @@ config AT91_ADC
>> config AT91_SAMA5D2_ADC
>> tristate "Atmel AT91 SAMA5D2 ADC"
>> depends on ARCH_AT91 || COMPILE_TEST
>> + depends on HAS_IOMEM
>> help
>> Say yes here to build support for Atmel SAMA5D2 ADC which is
>> available on SAMA5D2 SoC family.
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-28 8:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-04 1:05 [PATCH] iio: adc: Fix build error of missing devm_ioremap_resource on UM Krzysztof Kozlowski
2016-03-05 18:49 ` Jonathan Cameron
2016-03-28 8:45 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).