* [PATCH] iio: tools: generic_buffer: auto-enable channels
@ 2016-03-24 9:43 Linus Walleij
2016-03-24 9:56 ` Daniel Baluta
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2016-03-24 9:43 UTC (permalink / raw)
To: Jonathan Cameron, linux-iio; +Cc: Linus Walleij
If no channels are enabled when we run generic_buffer on a
device, well then just enable all of them, run the sampling
and disable them all again afterwards.
This is extremely useful when I'm low-level testing my
sensors with interrupts and triggers, sample session:
root@Ux500:/ lsiio
Device 000: lsm303dlh_accel
Device 001: lis331dl_accel
Device 002: l3g4200d
Device 003: lsm303dlh_magn
Device 004: lps001wp
Trigger 000: lsm303dlh_accel-trigger
Trigger 001: lis331dl_accel-trigger
Trigger 002: l3g4200d-trigger
root@Ux500:/ generic_buffer -c 10 -n l3g4200d
iio device number being used is 2
iio trigger number being used is 2
No channels are enabled, enabling all channels
Enabling: in_anglvel_x_en
Enabling: in_anglvel_y_en
Enabling: in_anglvel_z_en
Enabling: in_timestamp_en
/sys/bus/iio/devices/iio:device2 l3g4200d-trigger
-3.593664 -0.713133 4.870143 946684863662292480
3.225546 0.867357 -4.945878 946684863671875000
-0.676413 0.127296 0.106641 946684863681488037
-0.661113 0.110160 0.128826 946684863690673828
-0.664173 0.113067 0.123471 946684863700683593
-0.664938 0.109395 0.124848 946684863710144042
-0.664173 0.110619 0.130203 946684863719512939
-0.666162 0.111231 0.132651 946684863729125976
-0.668610 0.111690 0.130662 946684863738739013
-0.660501 0.110466 0.131733 946684863748565673
Disabling: in_anglvel_x_en
Disabling: in_anglvel_y_en
Disabling: in_anglvel_z_en
Disabling: in_timestamp_en
Pure awesomeness. If some channels have been enabled through
scripts or manual interaction, nothing happens.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
tools/iio/generic_buffer.c | 77 +++++++++++++++++++++++++++++++++++++++++-----
tools/iio/iio_utils.h | 7 +++++
2 files changed, 77 insertions(+), 7 deletions(-)
diff --git a/tools/iio/generic_buffer.c b/tools/iio/generic_buffer.c
index c42b7f836b48..fd74495197c2 100644
--- a/tools/iio/generic_buffer.c
+++ b/tools/iio/generic_buffer.c
@@ -191,6 +191,46 @@ void process_scan(char *data,
printf("\n");
}
+int enable_disable_all_channels(char *dev_dir_name, int enable)
+{
+ const struct dirent *ent;
+ char scanelemdir[256];
+ DIR *dp;
+ int ret;
+
+ snprintf(scanelemdir, sizeof(scanelemdir),
+ FORMAT_SCAN_ELEMENTS_DIR, dev_dir_name);
+ scanelemdir[sizeof(scanelemdir)-1] = '\0';
+
+ dp = opendir(scanelemdir);
+ if (!dp) {
+ fprintf(stderr, "Enabling/disabling channels: can't open %s\n",
+ scanelemdir);
+ return -EIO;
+ }
+
+ ret = -ENOENT;
+ while (ent = readdir(dp), ent) {
+ if (check_suffix(ent->d_name, "_en")) {
+ printf("%sabling: %s\n",
+ enable ? "En" : "Dis",
+ ent->d_name);
+ ret = write_sysfs_int(ent->d_name, scanelemdir,
+ enable);
+ if (ret < 0)
+ fprintf(stderr, "Failed to enable/disable %s\n",
+ ent->d_name);
+ }
+ }
+
+ if (closedir(dp) == -1) {
+ perror("Enabling/disabling channels: "
+ "Failed to close directory");
+ return -errno;
+ }
+ return 0;
+}
+
void print_usage(void)
{
fprintf(stderr, "Usage: generic_buffer [options]...\n"
@@ -225,6 +265,7 @@ int main(int argc, char **argv)
int scan_size;
int noevents = 0;
int notrigger = 0;
+ int autochannels = 0;
char *dummy;
struct iio_channel_info *channels;
@@ -342,12 +383,29 @@ int main(int argc, char **argv)
}
if (!num_channels) {
fprintf(stderr,
- "No channels are enabled, we have nothing to scan.\n");
- fprintf(stderr, "Enable channels manually in "
- FORMAT_SCAN_ELEMENTS_DIR
- "/*_en and try again.\n", dev_dir_name);
- ret = -ENOENT;
- goto error_free_triggername;
+ "No channels are enabled, enabling all channels\n");
+
+ ret = enable_disable_all_channels(dev_dir_name, 1);
+ if (ret) {
+ fprintf(stderr, "Failed to enable all channels\n");
+ goto error_free_triggername;
+ }
+
+ /* This flags that we need to disable the channels again */
+ autochannels = 1;
+ ret = build_channel_array(dev_dir_name, &channels,
+ &num_channels);
+ if (ret) {
+ fprintf(stderr, "Problem reading scan element "
+ "information\n"
+ "diag %s\n", dev_dir_name);
+ goto error_disable_channels;
+ }
+ if (!num_channels) {
+ fprintf(stderr, "Still no channels after "
+ "auto-enabling, giving up\n");
+ goto error_disable_channels;
+ }
}
/*
@@ -479,7 +537,12 @@ error_free_channels:
error_free_triggername:
if (datardytrigger)
free(trigger_name);
-
+error_disable_channels:
+ if (autochannels) {
+ ret = enable_disable_all_channels(dev_dir_name, 0);
+ if (ret)
+ fprintf(stderr, "Failed to disable all channels\n");
+ }
error_free_dev_dir_name:
free(dev_dir_name);
diff --git a/tools/iio/iio_utils.h b/tools/iio/iio_utils.h
index e3503bfe538b..9d5601421820 100644
--- a/tools/iio/iio_utils.h
+++ b/tools/iio/iio_utils.h
@@ -52,6 +52,13 @@ struct iio_channel_info {
unsigned location;
};
+static inline int check_suffix(const char *str, const char *suffix)
+{
+ return strlen(str) > strlen(suffix) &&
+ strncmp(str+strlen(str)-strlen(suffix),
+ suffix, strlen(suffix)) == 0;
+}
+
int iioutils_break_up_name(const char *full_name, char **generic_name);
int iioutils_get_type(unsigned *is_signed, unsigned *bytes, unsigned *bits_used,
unsigned *shift, uint64_t *mask, unsigned *be,
--
2.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: tools: generic_buffer: auto-enable channels
2016-03-24 9:43 [PATCH] iio: tools: generic_buffer: auto-enable channels Linus Walleij
@ 2016-03-24 9:56 ` Daniel Baluta
2016-03-28 9:43 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Baluta @ 2016-03-24 9:56 UTC (permalink / raw)
To: Linus Walleij; +Cc: Jonathan Cameron, linux-iio@vger.kernel.org
On Thu, Mar 24, 2016 at 11:43 AM, Linus Walleij
<linus.walleij@linaro.org> wrote:
> If no channels are enabled when we run generic_buffer on a
> device, well then just enable all of them, run the sampling
> and disable them all again afterwards.
>
> This is extremely useful when I'm low-level testing my
> sensors with interrupts and triggers, sample session:
>
> root@Ux500:/ lsiio
> Device 000: lsm303dlh_accel
> Device 001: lis331dl_accel
> Device 002: l3g4200d
> Device 003: lsm303dlh_magn
> Device 004: lps001wp
> Trigger 000: lsm303dlh_accel-trigger
> Trigger 001: lis331dl_accel-trigger
> Trigger 002: l3g4200d-trigger
>
> root@Ux500:/ generic_buffer -c 10 -n l3g4200d
> iio device number being used is 2
> iio trigger number being used is 2
> No channels are enabled, enabling all channels
> Enabling: in_anglvel_x_en
> Enabling: in_anglvel_y_en
> Enabling: in_anglvel_z_en
> Enabling: in_timestamp_en
> /sys/bus/iio/devices/iio:device2 l3g4200d-trigger
> -3.593664 -0.713133 4.870143 946684863662292480
> 3.225546 0.867357 -4.945878 946684863671875000
> -0.676413 0.127296 0.106641 946684863681488037
> -0.661113 0.110160 0.128826 946684863690673828
> -0.664173 0.113067 0.123471 946684863700683593
> -0.664938 0.109395 0.124848 946684863710144042
> -0.664173 0.110619 0.130203 946684863719512939
> -0.666162 0.111231 0.132651 946684863729125976
> -0.668610 0.111690 0.130662 946684863738739013
> -0.660501 0.110466 0.131733 946684863748565673
> Disabling: in_anglvel_x_en
> Disabling: in_anglvel_y_en
> Disabling: in_anglvel_z_en
> Disabling: in_timestamp_en
>
> Pure awesomeness. If some channels have been enabled through
> scripts or manual interaction, nothing happens.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Indeed. This is very useful!
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
https://imgflip.com/i/11cof2 :)
thanks,
Daniel.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: tools: generic_buffer: auto-enable channels
2016-03-24 9:56 ` Daniel Baluta
@ 2016-03-28 9:43 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2016-03-28 9:43 UTC (permalink / raw)
To: Daniel Baluta, Linus Walleij; +Cc: linux-iio@vger.kernel.org
On 24/03/16 09:56, Daniel Baluta wrote:
> On Thu, Mar 24, 2016 at 11:43 AM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
>> If no channels are enabled when we run generic_buffer on a
>> device, well then just enable all of them, run the sampling
>> and disable them all again afterwards.
>>
>> This is extremely useful when I'm low-level testing my
>> sensors with interrupts and triggers, sample session:
>>
>> root@Ux500:/ lsiio
>> Device 000: lsm303dlh_accel
>> Device 001: lis331dl_accel
>> Device 002: l3g4200d
>> Device 003: lsm303dlh_magn
>> Device 004: lps001wp
>> Trigger 000: lsm303dlh_accel-trigger
>> Trigger 001: lis331dl_accel-trigger
>> Trigger 002: l3g4200d-trigger
>>
>> root@Ux500:/ generic_buffer -c 10 -n l3g4200d
>> iio device number being used is 2
>> iio trigger number being used is 2
>> No channels are enabled, enabling all channels
>> Enabling: in_anglvel_x_en
>> Enabling: in_anglvel_y_en
>> Enabling: in_anglvel_z_en
>> Enabling: in_timestamp_en
>> /sys/bus/iio/devices/iio:device2 l3g4200d-trigger
>> -3.593664 -0.713133 4.870143 946684863662292480
>> 3.225546 0.867357 -4.945878 946684863671875000
>> -0.676413 0.127296 0.106641 946684863681488037
>> -0.661113 0.110160 0.128826 946684863690673828
>> -0.664173 0.113067 0.123471 946684863700683593
>> -0.664938 0.109395 0.124848 946684863710144042
>> -0.664173 0.110619 0.130203 946684863719512939
>> -0.666162 0.111231 0.132651 946684863729125976
>> -0.668610 0.111690 0.130662 946684863738739013
>> -0.660501 0.110466 0.131733 946684863748565673
>> Disabling: in_anglvel_x_en
>> Disabling: in_anglvel_y_en
>> Disabling: in_anglvel_z_en
>> Disabling: in_timestamp_en
>>
>> Pure awesomeness. If some channels have been enabled through
>> scripts or manual interaction, nothing happens.
>>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> Indeed. This is very useful!
>
> Acked-by: Daniel Baluta <daniel.baluta@intel.com>
>
> https://imgflip.com/i/11cof2 :)
It's extremely useful on devices where all the channels can be enabled.
Unfortunately the possible channel sets are not exported and for
quite a lot of devices you cannot configure reading all channels at once.
Look at the more complex available_scan_mask options that exist or
anything with the onehot callback used.
How about doing it on a parameter so -a (if not used - can't remember)
for enable all channels? Then it won't do weird things unless someone
foolishly enables it on a device where you can't have buffered access
to all channels at once.
Jonathan
>
> thanks,
> Daniel.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-28 9:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-24 9:43 [PATCH] iio: tools: generic_buffer: auto-enable channels Linus Walleij
2016-03-24 9:56 ` Daniel Baluta
2016-03-28 9:43 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).