From: Jonathan Cameron <jic23@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: tools: make generic_buffer look for "-trigger"
Date: Mon, 28 Mar 2016 11:16:00 +0100 [thread overview]
Message-ID: <56F90460.9020507@kernel.org> (raw)
In-Reply-To: <1458808754-31088-1-git-send-email-linus.walleij@linaro.org>
On 24/03/16 08:39, Linus Walleij wrote:
> All the ST Sensors use the old "<foo>-trigger" rather than the
> standard "<foo>-devN" new standard suffix for triggers. Now much
> to do about it since it is ABI, but make the testing tools
> recognize it too.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
It is a bit ugly to do the find_trigger_by_name call twice, but I couldn't
find a cleaner way of doing it either, so fair enough.
Applied to the togreg branch of iio.git. Initially pushed out as testing
for the autobuilders to play with it (possibly - adding tools/iio has been
requested and they weren't against it...)
Jonathan
> ---
> tools/iio/generic_buffer.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/tools/iio/generic_buffer.c b/tools/iio/generic_buffer.c
> index 01c4f67801e0..c42b7f836b48 100644
> --- a/tools/iio/generic_buffer.c
> +++ b/tools/iio/generic_buffer.c
> @@ -304,7 +304,19 @@ int main(int argc, char **argv)
> }
> }
>
> - /* Verify the trigger exists */
> + /* Look for this "-devN" trigger */
> + trig_num = find_type_by_name(trigger_name, "trigger");
> + if (trig_num < 0) {
> + /* OK try the simpler "-trigger" suffix instead */
> + free(trigger_name);
> + ret = asprintf(&trigger_name,
> + "%s-trigger", device_name);
> + if (ret < 0) {
> + ret = -ENOMEM;
> + goto error_free_dev_dir_name;
> + }
> + }
> +
> trig_num = find_type_by_name(trigger_name, "trigger");
> if (trig_num < 0) {
> fprintf(stderr, "Failed to find the trigger %s\n",
>
prev parent reply other threads:[~2016-03-28 10:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 8:39 [PATCH] iio: tools: make generic_buffer look for "-trigger" Linus Walleij
2016-03-28 10:16 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F90460.9020507@kernel.org \
--to=jic23@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).