Linux IIO development
 help / color / mirror / Atom feed
From: "Nuno Sá" <noname.nuno@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>,
	Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@kernel.org>
Cc: nuno.sa@analog.com, linux-iio@vger.kernel.org,
	Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	David Lechner <dlechner@baylibre.com>
Subject: Re: [PATCH v2] iio: adc: adi-axi-adc: make sure DRP is locked on enable
Date: Wed, 29 May 2024 09:18:11 +0200	[thread overview]
Message-ID: <56bbd0b7b2618d803a38b1638dc2820599086f56.camel@gmail.com> (raw)
In-Reply-To: <20240525175418.7b537296@jic23-huawei>

On Sat, 2024-05-25 at 17:54 +0100, Jonathan Cameron wrote:
> On Wed, 22 May 2024 15:14:56 +0200
> Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@kernel.org> wrote:
> 
> > From: Nuno Sa <nuno.sa@analog.com>
> > 
> > When enabling the core, make sure DRP (Dynamic Reconfiguration Port)
> > is locked. Most of the designs don't really use it but we still get the
> > lock bit set. So let's do it all the time so the code is generic.
> > 
> > While at it add proper mutex guards as we should not be able to disable
> > the core in the middle of enabling it. Also reduce the timeout time to 1
> > microsecond as it seems to be enough and goes in line with what we have
> > on the similar DAC core (adi-axi-dac).
> > 
> > Signed-off-by: Nuno Sa <nuno.sa@analog.com>
> Sounds like a fix, so fixes tag?
> 

Can add one even though we do not need to rush any backport as the current user we
have for this is not doing anything crazy :).

Anyways, I'll then split the fix into a separate patch so it's more clear.

- Nuno Sá

      reply	other threads:[~2024-05-29  7:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22 13:14 [PATCH v2] iio: adc: adi-axi-adc: make sure DRP is locked on enable Nuno Sa via B4 Relay
2024-05-25 16:54 ` Jonathan Cameron
2024-05-29  7:18   ` Nuno Sá [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56bbd0b7b2618d803a38b1638dc2820599086f56.camel@gmail.com \
    --to=noname.nuno@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=devnull+nuno.sa.analog.com@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox