From: Jonathan Cameron <jic23@kernel.org>
To: Crestez Dan Leonard <leonard.crestez@intel.com>,
linux-iio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Daniel Baluta <daniel.baluta@intel.com>
Subject: Re: [PATCH 2/5] iio: inv_mpu6050: Remove inv_mpu6050_hw.num_reg
Date: Sun, 24 Apr 2016 12:12:05 +0100 [thread overview]
Message-ID: <56c9b2b1-1af7-0b51-372c-94ddba0916c6@kernel.org> (raw)
In-Reply-To: <a6476cd8bc1c6493e93a17174ff6339668130d48.1461156671.git.leonard.crestez@intel.com>
On 20/04/16 14:15, Crestez Dan Leonard wrote:
> This field was unused and incorrect for mpu6500.
>
> Signed-off-by: Crestez Dan Leonard <leonard.crestez@intel.com>.
This one I think I can safely take :)
Good spot
> ---
> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 3 ---
> drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 2 --
> 2 files changed, 5 deletions(-)
>
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> index 52e62b3..faccabafc 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> @@ -91,19 +91,16 @@ static const struct inv_mpu6050_chip_config chip_config_6050 = {
> /* Indexed by enum inv_devices */
> static const struct inv_mpu6050_hw hw_info[] = {
> {
> - .num_reg = 117,
> .name = "MPU6050",
> .reg = ®_set_6050,
> .config = &chip_config_6050,
> },
> {
> - .num_reg = 117,
> .name = "MPU6500",
> .reg = ®_set_6500,
> .config = &chip_config_6050,
> },
> {
> - .num_reg = 117,
> .name = "MPU6000",
> .reg = ®_set_6050,
> .config = &chip_config_6050,
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h
> index e302a49..c66dbfc 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h
> @@ -93,13 +93,11 @@ struct inv_mpu6050_chip_config {
>
> /**
> * struct inv_mpu6050_hw - Other important hardware information.
> - * @num_reg: Number of registers on device.
> * @name: name of the chip.
> * @reg: register map of the chip.
> * @config: configuration of the chip.
> */
> struct inv_mpu6050_hw {
> - u8 num_reg;
> u8 *name;
> const struct inv_mpu6050_reg_map *reg;
> const struct inv_mpu6050_chip_config *config;
>
next prev parent reply other threads:[~2016-04-24 11:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 13:15 [PATCH 0/5] iio: inv_mpu6050: Cleanup chip types and add mpu9150 Crestez Dan Leonard
2016-04-20 13:15 ` [PATCH 1/5] iio: inv_mpu6050: Cleanup hw_info mapping Crestez Dan Leonard
2016-04-24 11:10 ` Jonathan Cameron
2016-04-25 18:41 ` Jonathan Cameron
2016-04-20 13:15 ` [PATCH 2/5] iio: inv_mpu6050: Remove inv_mpu6050_hw.num_reg Crestez Dan Leonard
2016-04-24 11:12 ` Jonathan Cameron [this message]
2016-04-25 18:43 ` Jonathan Cameron
2016-04-20 13:15 ` [PATCH 3/5] iio: inv_mpu6050: Check WHO_AM_I register on probe Crestez Dan Leonard
2016-04-24 11:14 ` Jonathan Cameron
2016-04-25 11:17 ` Crestez Dan Leonard
2016-04-25 18:09 ` Jonathan Cameron
2016-04-20 13:15 ` [PATCH 4/5] iio: inv_mpu6050: Add spi_device_id for INV_MPU6500 Crestez Dan Leonard
2016-04-20 13:15 ` [PATCH 5/5] iio: inv_mpu6050: Add explicit support for MPU9150 Crestez Dan Leonard
[not found] ` <76645673-6d2c-3d51-a689-1c9310cbc765@kernel.org>
2016-04-25 17:56 ` Ge Gao
2016-04-25 19:20 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56c9b2b1-1af7-0b51-372c-94ddba0916c6@kernel.org \
--to=jic23@kernel.org \
--cc=daniel.baluta@intel.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=leonard.crestez@intel.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).