From: Jonathan Cameron <jic23@kernel.org>
To: Rob Herring <robh@kernel.org>, michael.hennerich@analog.com
Cc: linus.walleij@linaro.org, gnurou@gmail.com, lars@metafoo.de,
knaack.h@gmx.de, paul.cercueil@analog.com, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v6] iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs
Date: Sun, 10 Apr 2016 14:29:52 +0100 [thread overview]
Message-ID: <570A5550.20107@kernel.org> (raw)
In-Reply-To: <20160407175748.GL32257@rob-hp-laptop>
On 07/04/16 18:57, Rob Herring wrote:
> On Tue, Apr 05, 2016 at 09:46:19AM +0200, michael.hennerich@analog.com wrote:
>> From: Paul Cercueil <paul.cercueil@analog.com>
>>
>> This patch adds support for the AD5592R (spi) and AD5593R (i2c)
>> ADC/DAC/GPIO devices.
>>
>> Signed-off-by: Paul Cercueil <paul.cercueil@analog.com>
>> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>>
>> ---
>>
>> Changes since v1:
>> * Fix mutex usage
>> * Remove unnecessary NULL pointer guards
>> * Add comment explaining the invalid data read
>> * AD5593R Remove surplus adc readback
>>
>> Changes since v2:
>> * Use child nodes to describe channels
>> * Fix probe return and driver remove path
>> * Move locking closer to where its used
>> * Remove WARN_ON but return error
>> * Remove OPEN DRAIN configuration option
>>
>> Changes since v3:
>> * Documentation: Add missing vendor prefixes in the examples
>> * Minor function reordering in remove() to match the reverse of probe()
>>
>> Changes since v4:
>> * Documentation: Add missing gpio bindings
>> * Kconfig: Select GPIOLIB and remove ifdefs in code
>> * Remove surplus error check in ad5592r_gpio_request()
>> * Add comment about reset magic
>>
>> Changes since v5:
>> * Remove surplus error check
>> * Remove additional ifdef CONFIG_GPIOLIB guards in the header
>> * Bindings: Add additional comments about CH_MODE_DAC_AND_ADC mode
>> ---
>> .../devicetree/bindings/iio/dac/ad5592r.txt | 155 +++++
>
> I've acked this twice before, and the last change seems minor.
> Please add acks unless it is more than minor changes and you need it
> reviewed again.
>
> Acked-by: Rob Herring <robh@kernel.org>
Applied to the togreg branch of iio.git - initially pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
>
>> drivers/iio/dac/Kconfig | 27 +
>> drivers/iio/dac/Makefile | 3 +
>> drivers/iio/dac/ad5592r-base.c | 691 +++++++++++++++++++++
>> drivers/iio/dac/ad5592r-base.h | 76 +++
>> drivers/iio/dac/ad5592r.c | 164 +++++
>> drivers/iio/dac/ad5593r.c | 131 ++++
>> include/dt-bindings/iio/adi,ad5592r.h | 16 +
>> 8 files changed, 1263 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/iio/dac/ad5592r.txt
>> create mode 100644 drivers/iio/dac/ad5592r-base.c
>> create mode 100644 drivers/iio/dac/ad5592r-base.h
>> create mode 100644 drivers/iio/dac/ad5592r.c
>> create mode 100644 drivers/iio/dac/ad5593r.c
>> create mode 100644 include/dt-bindings/iio/adi,ad5592r.h
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2016-04-10 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 7:46 [PATCH v6] iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs michael.hennerich
2016-04-07 17:57 ` Rob Herring
2016-04-10 13:29 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570A5550.20107@kernel.org \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michael.hennerich@analog.com \
--cc=paul.cercueil@analog.com \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).