* [PATCH v2 27/30] iio: use parity32 in adxrs450 [not found] <57031D9D.801@gmail.com> @ 2016-04-06 10:16 ` zengzhaoxiu 2016-04-10 14:37 ` Jonathan Cameron 0 siblings, 1 reply; 5+ messages in thread From: zengzhaoxiu @ 2016-04-06 10:16 UTC (permalink / raw) To: lars, Michael.Hennerich, jic23, knaack.h, pmeerw Cc: linux-iio, linux-kernel, Zhaoxiu Zeng From: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com> Signed-off-by: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com> --- drivers/iio/gyro/adxrs450.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/gyro/adxrs450.c b/drivers/iio/gyro/adxrs450.c index a330d42..307f55b 100644 --- a/drivers/iio/gyro/adxrs450.c +++ b/drivers/iio/gyro/adxrs450.c @@ -109,7 +109,7 @@ static int adxrs450_spi_read_reg_16(struct iio_dev *indio_dev, mutex_lock(&st->buf_lock); tx = ADXRS450_READ_DATA | (reg_address << 17); - if (!(hweight32(tx) & 1)) + if (!parity32(tx)) tx |= ADXRS450_P; st->tx = cpu_to_be32(tx); @@ -145,7 +145,7 @@ static int adxrs450_spi_write_reg_16(struct iio_dev *indio_dev, mutex_lock(&st->buf_lock); tx = ADXRS450_WRITE_DATA | (reg_address << 17) | (val << 1); - if (!(hweight32(tx) & 1)) + if (!parity32(tx)) tx |= ADXRS450_P; st->tx = cpu_to_be32(tx); -- 2.5.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 27/30] iio: use parity32 in adxrs450 2016-04-06 10:16 ` [PATCH v2 27/30] iio: use parity32 in adxrs450 zengzhaoxiu @ 2016-04-10 14:37 ` Jonathan Cameron 2016-04-10 14:41 ` Lars-Peter Clausen 0 siblings, 1 reply; 5+ messages in thread From: Jonathan Cameron @ 2016-04-10 14:37 UTC (permalink / raw) To: zengzhaoxiu, lars, Michael.Hennerich, knaack.h, pmeerw Cc: linux-iio, linux-kernel, Zhaoxiu Zeng On 06/04/16 11:16, zengzhaoxiu@163.com wrote: > From: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com> > > Signed-off-by: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com> Applied to the togreg branch of iio.git as you seem to have addressed Lars' comments. Thanks, Jonathan > --- > drivers/iio/gyro/adxrs450.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/gyro/adxrs450.c b/drivers/iio/gyro/adxrs450.c > index a330d42..307f55b 100644 > --- a/drivers/iio/gyro/adxrs450.c > +++ b/drivers/iio/gyro/adxrs450.c > @@ -109,7 +109,7 @@ static int adxrs450_spi_read_reg_16(struct iio_dev *indio_dev, > mutex_lock(&st->buf_lock); > tx = ADXRS450_READ_DATA | (reg_address << 17); > > - if (!(hweight32(tx) & 1)) > + if (!parity32(tx)) > tx |= ADXRS450_P; > > st->tx = cpu_to_be32(tx); > @@ -145,7 +145,7 @@ static int adxrs450_spi_write_reg_16(struct iio_dev *indio_dev, > mutex_lock(&st->buf_lock); > tx = ADXRS450_WRITE_DATA | (reg_address << 17) | (val << 1); > > - if (!(hweight32(tx) & 1)) > + if (!parity32(tx)) > tx |= ADXRS450_P; > > st->tx = cpu_to_be32(tx); > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 27/30] iio: use parity32 in adxrs450 2016-04-10 14:37 ` Jonathan Cameron @ 2016-04-10 14:41 ` Lars-Peter Clausen 2016-04-10 15:13 ` Jonathan Cameron 0 siblings, 1 reply; 5+ messages in thread From: Lars-Peter Clausen @ 2016-04-10 14:41 UTC (permalink / raw) To: Jonathan Cameron, zengzhaoxiu, Michael.Hennerich, knaack.h, pmeerw Cc: linux-iio, linux-kernel, Zhaoxiu Zeng On 04/10/2016 04:37 PM, Jonathan Cameron wrote: > On 06/04/16 11:16, zengzhaoxiu@163.com wrote: >> From: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com> >> >> Signed-off-by: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com> > Applied to the togreg branch of iio.git as you seem to have addressed > Lars' comments. The whole series needs to go through the same tree since the new functions are introduced in the beginning. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 27/30] iio: use parity32 in adxrs450 2016-04-10 14:41 ` Lars-Peter Clausen @ 2016-04-10 15:13 ` Jonathan Cameron 2016-04-10 15:14 ` Jonathan Cameron 0 siblings, 1 reply; 5+ messages in thread From: Jonathan Cameron @ 2016-04-10 15:13 UTC (permalink / raw) To: Lars-Peter Clausen, zengzhaoxiu, Michael.Hennerich, knaack.h, pmeerw Cc: linux-iio, linux-kernel, Zhaoxiu Zeng On 10/04/16 15:41, Lars-Peter Clausen wrote: > On 04/10/2016 04:37 PM, Jonathan Cameron wrote: >> On 06/04/16 11:16, zengzhaoxiu@163.com wrote: >>> From: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com> >>> >>> Signed-off-by: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com> >> Applied to the togreg branch of iio.git as you seem to have addressed >> Lars' comments. > > The whole series needs to go through the same tree since the new functions > are introduced in the beginning. Yeah, I just realized that when my build test failed! Acked-by: Jonathan Cameron <jic23@kernel.org> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 27/30] iio: use parity32 in adxrs450 2016-04-10 15:13 ` Jonathan Cameron @ 2016-04-10 15:14 ` Jonathan Cameron 0 siblings, 0 replies; 5+ messages in thread From: Jonathan Cameron @ 2016-04-10 15:14 UTC (permalink / raw) To: Lars-Peter Clausen, zengzhaoxiu, Michael.Hennerich, knaack.h, pmeerw Cc: linux-iio, linux-kernel, Zhaoxiu Zeng On 10/04/16 16:13, Jonathan Cameron wrote: > On 10/04/16 15:41, Lars-Peter Clausen wrote: >> On 04/10/2016 04:37 PM, Jonathan Cameron wrote: >>> On 06/04/16 11:16, zengzhaoxiu@163.com wrote: >>>> From: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com> >>>> >>>> Signed-off-by: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com> >>> Applied to the togreg branch of iio.git as you seem to have addressed >>> Lars' comments. >> >> The whole series needs to go through the same tree since the new functions >> are introduced in the beginning. > Yeah, I just realized that when my build test failed! > > Acked-by: Jonathan Cameron <jic23@kernel.org> Backed out of the togreg branch of iio.git... oops and thanks Lars! >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-04-10 15:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <57031D9D.801@gmail.com>
2016-04-06 10:16 ` [PATCH v2 27/30] iio: use parity32 in adxrs450 zengzhaoxiu
2016-04-10 14:37 ` Jonathan Cameron
2016-04-10 14:41 ` Lars-Peter Clausen
2016-04-10 15:13 ` Jonathan Cameron
2016-04-10 15:14 ` Jonathan Cameron
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).