From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:53211 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751385AbcDQLYp (ORCPT ); Sun, 17 Apr 2016 07:24:45 -0400 Subject: Re: [PATCH 3/4] iio: st_sensors: verify interrupt event to status To: Linus Walleij References: <1458825486-17188-1-git-send-email-linus.walleij@linaro.org> <1458825486-17188-3-git-send-email-linus.walleij@linaro.org> <56F8E6AC.9090609@kernel.org> Cc: "linux-iio@vger.kernel.org" , Giuseppe Barba , Denis Ciocca From: Jonathan Cameron Message-ID: <5713727B.9030309@kernel.org> Date: Sun, 17 Apr 2016 12:24:43 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 12/04/16 13:34, Linus Walleij wrote: > On Mon, Mar 28, 2016 at 10:09 AM, Jonathan Cameron wrote: >> On 24/03/16 13:18, Linus Walleij wrote: >>> This makes all ST sensor drivers check that they actually have >>> new data available for the requested channel(s) before claiming >>> an IRQ, by reading the status register (which is conveniently >>> the same for all ST sensors) and check that the channel has new >>> data before proceeding to read it and fill the buffer. >>> >>> This way sensors can share an interrupt line: it can be flaged >>> as shared and then the sensor that did not fire will return >>> NO_IRQ, and the sensor that fired will handle the IRQ and >>> return IRQ_HANDLED. >>> >> Looks good and even matches on the archaic lis3l02dq I keep meaning >> to add to the driver :) (had that datasheet lying around) >> >> One day we'll figure out how to report 'overruns' sensibly at >> which point we can use the other bits in that register as well. >> >> Anyhow, will let this sit just a little longer as would like Denis >> and/or Giuseppe to have a look at it as well. > > If no further comments I guess this could be applied? > > Yours, > Linus Walleij Agreed and applied to the togreg branch of iio.git - initially pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >