From: Lars-Peter Clausen <lars@metafoo.de>
To: Crestez Dan Leonard <leonard.crestez@intel.com>,
Daniel Baluta <daniel.baluta@gmail.com>,
Yong Li <sdliyong@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Hartmut Knaack" <knaack.h@gmx.de>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
"Krzysztof Kozłowski" <k.kozlowski@samsung.com>,
"Matt Ranostaj" <mranostay@gmail.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: tmp006: Set correct iio name
Date: Thu, 28 Apr 2016 10:25:40 +0200 [thread overview]
Message-ID: <5721C904.3010505@metafoo.de> (raw)
In-Reply-To: <5720EFAA.3040407@intel.com>
On 04/27/2016 06:58 PM, Crestez Dan Leonard wrote:
> On 04/26/2016 06:21 PM, Daniel Baluta wrote:
>> On Tue, Apr 26, 2016 at 4:14 PM, Yong Li <sdliyong@gmail.com> wrote:
>>> I am thinking if there is any application is using this incorrect
>>> name, the application should be fix too
>>
>> The rule is: "Don't break the userspace ABI". So, if we got this wrong
>> from the beginning we are stuck with this name.
>>
>> The only thing that can save the situation is to know that there is no
>> application relying on the name :).
>>
> But if iio_dev->name is supposed to be the "model name" then setting it
> to the i2c dev_name is just plain wrong, right? Correcting this could be
> considered a bugfix.
It's clearly wrong. But the problem is there might be an application that
depends on the wrong behavior, the driver has been around for 2.5 years. So
it's difficult to fix. We might just go ahead in this case and take the
chance that nobody will complain. But if somebody complains this will bring
us the wrath of the Linus.
next prev parent reply other threads:[~2016-04-28 8:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 3:43 [PATCH] iio: tmp006: Set correct iio name Yong Li
2016-04-25 19:33 ` Jonathan Cameron
2016-04-25 20:59 ` Crestez Dan Leonard
2016-04-25 21:11 ` Jonathan Cameron
2016-04-26 10:57 ` Lars-Peter Clausen
2016-04-26 11:47 ` Yong Li
2016-04-26 12:01 ` Lars-Peter Clausen
2016-04-26 13:14 ` Yong Li
2016-04-26 15:21 ` Daniel Baluta
2016-04-27 3:42 ` Yong Li
2016-04-27 16:58 ` Crestez Dan Leonard
2016-04-28 8:25 ` Lars-Peter Clausen [this message]
2016-04-28 13:24 ` One Thousand Gnomes
2016-04-28 13:30 ` Peter Meerwald-Stadler
2016-04-28 14:19 ` Lars-Peter Clausen
2016-05-01 19:34 ` Jonathan Cameron
2016-05-03 9:43 ` [was iio: tmp006: Set correct iio name] how to support multiple instances of same device type Gregor Boirie
2016-05-03 12:00 ` Crestez Dan Leonard
2016-04-28 14:17 ` [PATCH] iio: tmp006: Set correct iio name Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5721C904.3010505@metafoo.de \
--to=lars@metafoo.de \
--cc=daniel.baluta@gmail.com \
--cc=jic23@kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=knaack.h@gmx.de \
--cc=leonard.crestez@intel.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mranostay@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=sdliyong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).