From: Laxman Dewangan <ldewangan@nvidia.com>
To: Jonathan Cameron <jic23@kernel.org>, <robh+dt@kernel.org>,
<corbet@lwn.net>, <lars@metafoo.de>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-doc@vger.kernel.org>, <linux-iio@vger.kernel.org>,
<linux-hwmon@vger.kernel.org>, Jean Delvare <khali@linux-fr.org>,
"Guenter Roeck" <linux@roeck-us.net>
Subject: Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221
Date: Fri, 3 Jun 2016 17:01:00 +0530 [thread overview]
Message-ID: <57516A74.4060008@nvidia.com> (raw)
In-Reply-To: <20f70b31-afb5-e012-0baf-ba0b83ac6d36@kernel.org>
On Friday 03 June 2016 03:46 PM, Jonathan Cameron wrote:
> On 03/06/16 11:06, Jonathan Cameron wrote:
>>
>> Code looks good, bu these more fundamental bits need sorting.
> Another minor point - why do the power calculations in driver?
> no hardware support for it, so why not just leave it to userspace?
Device supports the bus and shunt voltage monitoring. So even no
current. Also the warning/critical limit is for the voltage across shunt.
So should we only expose the shunt/bus voltage, no power/current?
I am thinking that user space should not know the platform and hence
shunt resistance and so exposing the current and power on bus is better
option.
next prev parent reply other threads:[~2016-06-03 11:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 12:34 [PATCH 1/3] iio: adc: ina3221: Add DT binding details Laxman Dewangan
2016-06-01 12:34 ` [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221 Laxman Dewangan
2016-06-03 10:06 ` Jonathan Cameron
2016-06-03 10:16 ` Jonathan Cameron
2016-06-03 11:31 ` Laxman Dewangan [this message]
2016-06-03 12:04 ` Jonathan Cameron
2016-06-03 12:03 ` Laxman Dewangan
2016-06-03 11:26 ` Laxman Dewangan
2016-06-03 12:09 ` Jonathan Cameron
2016-06-03 12:17 ` Laxman Dewangan
2016-06-03 13:29 ` Guenter Roeck
2016-06-03 14:14 ` Laxman Dewangan
2016-06-03 15:17 ` Andrew F. Davis
2016-06-07 22:30 ` Guenter Roeck
2016-06-08 15:04 ` Andrew F. Davis
2016-06-08 15:37 ` Laxman Dewangan
2016-06-01 12:34 ` [PATCH 3/3] iio: adc: ina3221: Add sysfs details " Laxman Dewangan
2016-06-03 10:26 ` Jonathan Cameron
2016-06-03 2:07 ` [PATCH 1/3] iio: adc: ina3221: Add DT binding details Rob Herring
2016-06-03 9:02 ` Laxman Dewangan
2016-06-03 10:19 ` Jonathan Cameron
2016-06-03 11:48 ` Laxman Dewangan
2016-06-03 12:11 ` Jonathan Cameron
2016-06-03 12:21 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57516A74.4060008@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=khali@linux-fr.org \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).