From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hqemgate16.nvidia.com ([216.228.121.65]:12516 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751312AbcFCLni (ORCPT ); Fri, 3 Jun 2016 07:43:38 -0400 Message-ID: <57516A74.4060008@nvidia.com> Date: Fri, 3 Jun 2016 17:01:00 +0530 From: Laxman Dewangan MIME-Version: 1.0 To: Jonathan Cameron , , , CC: , , , , , Jean Delvare , "Guenter Roeck" Subject: Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221 References: <1464784454-7988-1-git-send-email-ldewangan@nvidia.com> <1464784454-7988-2-git-send-email-ldewangan@nvidia.com> <44e28639-67b6-7586-5e6d-c0180ccded79@kernel.org> <20f70b31-afb5-e012-0baf-ba0b83ac6d36@kernel.org> In-Reply-To: <20f70b31-afb5-e012-0baf-ba0b83ac6d36@kernel.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Friday 03 June 2016 03:46 PM, Jonathan Cameron wrote: > On 03/06/16 11:06, Jonathan Cameron wrote: >> >> Code looks good, bu these more fundamental bits need sorting. > Another minor point - why do the power calculations in driver? > no hardware support for it, so why not just leave it to userspace? Device supports the bus and shunt voltage monitoring. So even no current. Also the warning/critical limit is for the voltage across shunt. So should we only expose the shunt/bus voltage, no power/current? I am thinking that user space should not know the platform and hence shunt resistance and so exposing the current and power on bus is better option.