From: Lars-Peter Clausen <lars@metafoo.de>
To: Linus Walleij <linus.walleij@linaro.org>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org,
Crestez Dan Leonard <leonard.crestez@intel.com>
Cc: Gregor Boirie <gregor.boirie@parrot.com>,
Richard Leitner <dev@g0hl1n.net>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>
Subject: Re: [PATCH] iio: ak8975: add Vid regulator, use optional API
Date: Thu, 16 Jun 2016 17:43:33 +0200 [thread overview]
Message-ID: <5762C925.70005@metafoo.de> (raw)
In-Reply-To: <1466091349-10307-1-git-send-email-linus.walleij@linaro.org>
On 06/16/2016 05:35 PM, Linus Walleij wrote:
[...]
> + data->vdd = devm_regulator_get_optional(&client->dev, "vdd");
> + if (!IS_ERR(data->vdd)) {
This ignores all errors silently and among other things breaks probe
deferral for the regulators.
> ret = regulator_enable(data->vdd);
> + if (ret) {
> + dev_warn(&client->dev,
> + "Failed to enable specified Vdd supply\n");
> + return ret;
> + }
> }
prev parent reply other threads:[~2016-06-16 15:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 15:35 [PATCH] iio: ak8975: add Vid regulator, use optional API Linus Walleij
2016-06-16 15:43 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5762C925.70005@metafoo.de \
--to=lars@metafoo.de \
--cc=dev@g0hl1n.net \
--cc=gregor.boirie@parrot.com \
--cc=jic23@kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=leonard.crestez@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox