From: Caesar Wang <sasukewxt@163.com>
To: jic23@kernel.org
Cc: Rob Herring <robh@kernel.org>, Caesar Wang <wxt@rock-chips.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
heiko@sntech.de, linux-iio@vger.kernel.org,
dianders@chromium.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org, john@metanate.com,
linux@roeck-us.net
Subject: Re: [PATCH v3 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it
Date: Sat, 30 Jul 2016 07:13:33 +0800 [thread overview]
Message-ID: <579BE31D.6020802@163.com> (raw)
In-Reply-To: <20160729212833.GA12688@rob-hp-laptop>
On 2016年07月30日 05:28, Rob Herring wrote:
> On Wed, Jul 27, 2016 at 10:24:04PM +0800, Caesar Wang wrote:
>> SARADC controller needs to be reset before programming it, otherwise
>> it will not function properly.
>>
>> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
>> Cc: Jonathan Cameron <jic23@kernel.org>
>> Cc: Heiko Stuebner <heiko@sntech.de>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: linux-iio@vger.kernel.org
>> Cc: linux-rockchip@lists.infradead.org
>> Tested-by: Guenter Roeck <linux@roeck-us.net>
>>
>> ---
>>
>> Changes in v3:
>> - %s/devm_reset_control_get_optional()/devm_reset_control_get()
>> - add Guente's test tag.
>>
>> Changes in v2:
>> - Make the reset as an optional property, since it should work
>> with old devicetrees as well.
>>
>> .../bindings/iio/adc/rockchip-saradc.txt | 7 +++++
>> drivers/iio/adc/Kconfig | 1 +
>> drivers/iio/adc/rockchip_saradc.c | 30 ++++++++++++++++++++++
>> 3 files changed, 38 insertions(+)
> Please add acks when posting new versions.
I didn't get your ACK when posting the V3. :-P
---
Your ack on 2016-07-27 23:12
.../bindings/iio/adc/rockchip-saradc.txt | 7 +++++
Acked-by: Rob Herring<robh@kernel.org>
>
> Rob
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2016-07-29 23:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 14:24 [PATCH v3 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it Caesar Wang
2016-07-27 14:24 ` [PATCH v3 2/4] arm64: dts: rockchip: add the saradc for rk3399 Caesar Wang
2016-07-27 14:50 ` Guenter Roeck
2016-08-24 9:32 ` Heiko Stübner
2016-07-27 14:24 ` [PATCH v3 3/4] arm64: dts: rockchip: add reset saradc node for rk3368 SoCs Caesar Wang
2016-07-27 14:51 ` Guenter Roeck
2016-08-22 17:19 ` Heiko Stuebner
2016-08-23 18:08 ` Jonathan Cameron
2016-07-27 14:24 ` [PATCH v3 4/4] arm: dts: rockchip: add reset node for the exist saradc SoCs Caesar Wang
2016-07-27 14:52 ` Guenter Roeck
2016-08-22 17:20 ` Heiko Stuebner
2016-08-23 18:09 ` Jonathan Cameron
2016-07-27 14:47 ` [PATCH v3 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it Peter Meerwald-Stadler
2016-07-29 23:21 ` Caesar Wang
2016-07-27 14:50 ` Guenter Roeck
2016-07-29 21:28 ` Rob Herring
2016-07-29 23:13 ` Caesar Wang [this message]
2016-07-29 23:13 ` Caesar Wang
2016-08-15 17:41 ` Jonathan Cameron
2016-08-15 17:43 ` Jonathan Cameron
2016-08-15 18:10 ` Caesar Wang
[not found] ` <7e84e59d-48ee-3e17-feff-8e57ae7c2b4b@kernel.org>
2016-08-21 20:01 ` Jonathan Cameron
2016-08-22 17:19 ` Heiko Stuebner
2016-08-23 18:08 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579BE31D.6020802@163.com \
--to=sasukewxt@163.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=jic23@kernel.org \
--cc=john@metanate.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).