From: Jonathan Cameron <jic23@kernel.org>
To: Song Hongyan <hongyan.song@intel.com>, linux-iio@vger.kernel.org
Cc: srinivas.pandruvada@intel.com
Subject: Re: [PATCH] iio: orientation: hid-sensor-rotation: Add PM function
Date: Sun, 30 Oct 2016 16:22:09 +0000 [thread overview]
Message-ID: <5c8d5490-93c9-a8c8-2d25-dbec3e2dc86f@kernel.org> (raw)
In-Reply-To: <1477357563-16794-1-git-send-email-hongyan.song@intel.com>
On 25/10/16 02:06, Song Hongyan wrote:
> Rotation sensor function does not work due to miss PM function.
> Add common hid sensor iio pm function for rotation sensor.
>
> Signed-off-by: Song Hongyan <hongyan.song@intel.com>
Does this completely prevent the driver working or merely make it consume
too much power?
Only really makes a difference to which route it takes to mainline and how
fast it gets there!
Jonathan
> ---
> drivers/iio/orientation/hid-sensor-rotation.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/orientation/hid-sensor-rotation.c b/drivers/iio/orientation/hid-sensor-rotation.c
> index b98b9d9..a97e802c 100644
> --- a/drivers/iio/orientation/hid-sensor-rotation.c
> +++ b/drivers/iio/orientation/hid-sensor-rotation.c
> @@ -335,6 +335,7 @@ static int hid_dev_rot_remove(struct platform_device *pdev)
> .id_table = hid_dev_rot_ids,
> .driver = {
> .name = KBUILD_MODNAME,
> + .pm = &hid_sensor_pm_ops,
> },
> .probe = hid_dev_rot_probe,
> .remove = hid_dev_rot_remove,
>
next prev parent reply other threads:[~2016-10-30 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 1:06 [PATCH] iio: orientation: hid-sensor-rotation: Add PM function Song Hongyan
2016-10-30 16:22 ` Jonathan Cameron [this message]
2016-10-31 0:32 ` Pandruvada, Srinivas
2016-11-05 17:49 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c8d5490-93c9-a8c8-2d25-dbec3e2dc86f@kernel.org \
--to=jic23@kernel.org \
--cc=hongyan.song@intel.com \
--cc=linux-iio@vger.kernel.org \
--cc=srinivas.pandruvada@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).