From: Jonathan Cameron <jic23@kernel.org>
To: Brian Masney <masneyb@onstation.org>, gregkh@linuxfoundation.org
Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 1/3] staging: iio: isl29018: remove unused variable and defines
Date: Sun, 25 Sep 2016 15:26:11 +0100 [thread overview]
Message-ID: <5c9abd6e-0e95-e89e-c0ef-99db8d5e7b75@kernel.org> (raw)
In-Reply-To: <1474803667-21776-1-git-send-email-masneyb@onstation.org>
On 25/09/16 12:41, Brian Masney wrote:
> Removes unused variable and associated #defines that was found using
> make W=1.
>
> Signed-off-by: Brian Masney <masneyb@onstation.org>
Hmm. Must have gotten left over from some refactoring that generates
these strings on the fly.
Applied to the togreg branch of iio.git - initially pushed out as
testing for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/staging/iio/light/isl29018.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
> index 76d9f74..ad282f1 100644
> --- a/drivers/staging/iio/light/isl29018.c
> +++ b/drivers/staging/iio/light/isl29018.c
> @@ -66,16 +66,6 @@
> #define ISL29035_BOUT_SHIFT 0x07
> #define ISL29035_BOUT_MASK (0x01 << ISL29035_BOUT_SHIFT)
>
> -#define ISL29018_INT_TIME_AVAIL "0.090000 0.005630 0.000351 0.000021"
> -#define ISL29023_INT_TIME_AVAIL "0.090000 0.005600 0.000352 0.000022"
> -#define ISL29035_INT_TIME_AVAIL "0.105000 0.006500 0.000410 0.000025"
> -
> -static const char * const int_time_avail[] = {
> - ISL29018_INT_TIME_AVAIL,
> - ISL29023_INT_TIME_AVAIL,
> - ISL29035_INT_TIME_AVAIL,
> -};
> -
> enum isl29018_int_time {
> ISL29018_INT_TIME_16,
> ISL29018_INT_TIME_12,
>
prev parent reply other threads:[~2016-09-25 14:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 11:41 [PATCH 1/3] staging: iio: isl29018: remove unused variable and defines Brian Masney
2016-09-25 11:41 ` [PATCH 2/3] staging: iio: isl29018: made error handling consistent Brian Masney
2016-09-25 14:28 ` Jonathan Cameron
2016-09-25 11:41 ` [PATCH 3/3] staging: iio: isl29018: fix comparison between signed and unsigned integers Brian Masney
2016-09-25 14:32 ` Jonathan Cameron
2016-09-25 14:26 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c9abd6e-0e95-e89e-c0ef-99db8d5e7b75@kernel.org \
--to=jic23@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-iio@vger.kernel.org \
--cc=masneyb@onstation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).