From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28AC21D63D1 for ; Mon, 16 Dec 2024 21:57:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734386270; cv=none; b=pTlGti9AX/cFnm4PbvgNIHgMyxYMzA4wWZvp52LVBDFssVpJDfwcTXUJDt5h2m4Ubv2n/fC1h2cawJ8JQ6BlNipd92K6PeH5xCI87SH0IHRlr6KVHGuT93wcAm6pgy0euGeIKLRKuMf8R5Y85nqqzCq9qHlTT2bIp4bltM6788I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734386270; c=relaxed/simple; bh=8rMjgRuVihNQt5T32hJGRBEMCzfZOnw4DNXhk2Ki1+o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PPfZ5ba6v9+Cp1mD4eCWtB1B1EwpKDGJ7ZFo/ibHOj6YF5o+9VJZOknyoh5QvyL9WyOtP1CI4G/mvq1PYxNu8QN7KdVcGrUiGVKZi+GdXeOm2go1QwyqHkJI9bZNY21ZYAOKoGkvTaFUAtDqOhiNdTSPw4GpRoVtrp/l5gGGlIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=3FeAdsSF; arc=none smtp.client-ip=209.85.167.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="3FeAdsSF" Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-3ea55a2a38bso2489769b6e.1 for ; Mon, 16 Dec 2024 13:57:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1734386267; x=1734991067; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fJ7JX9Gpdh7spzwrXAZK/HkmX7PEhbWKSdugnt63OEs=; b=3FeAdsSF/a1G9vXRpFxg1szI85HiYYmjhEQ+rugt6yWcAVR97FMG3MQyWFFh/Kkwaa io8Wiz/gS8Zuqt1t+H1JgyB3mdJIZNN41GSWpKIs1gdYk8PNoVcaNU4ZytyyIpIB+LAA rllEhroOKkZw88SDnxWPLDoLbyJA97DMezxUHlWy0XJ0mRDe+VjEFTtoAhK1FXt0LWoY qRfwdvrt7ahxgT126Ix8jlaXsslfrLJP/N5uq0Ycpj+1/kwopEkRJn0CfyMNmoaS2BPA /4XsmULRPps6Rzd1SLaSHOQKNJWIEr1tyLI3LHpNqyv/ZCyUW4lk9I0xrA47rkva7MzN msBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734386267; x=1734991067; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fJ7JX9Gpdh7spzwrXAZK/HkmX7PEhbWKSdugnt63OEs=; b=WThTpSSu752DrB/zYd4/6XDeox64rTIa3G/owezl+qRpGmpUOzqY1CJdBNHhXFDAwo u0XmMP3QM7s6jDu/9moRr5FBARrZsk7vr+EEq9NgOd6/MUOZfuEQTPc1jbkxVV9WET4K ibXYkGpWixlNTpVhtg9bvJ/N2zrCV8wgKthXA7eh09XPSaM7K2PJbq1/tingsubEnCAh 3tpl8EIQMDAdRQ831DljCd3HrVC83Hc5oJSyOpuAtrjKunnz5mCRkzyAmGPqbkuEvJ+E cmbPg3ccHOoUIsPltRec1ZcTjDfneW28bEM9ttbc92TMSBy8uz/Bv+cNVUDHQnXVz2cA 7KWw== X-Forwarded-Encrypted: i=1; AJvYcCUO9vCZRwk/R+k7wFRMrniPgtYNXl/8yWQBQo3XPsFA68tEPiF2i0ei10DtP055Xc7rjzmBPO1qRcE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+us2rVpYC42ijQsRlhvudLyu0miMnjA28tbpvrli4XmhkspRf ZdPjR5QMLQLVan7I7y/5gSTFXq8pZHuvxOgw8eihAUeez4/9aQnK9hpMVfx5pVM= X-Gm-Gg: ASbGncvWo5vNADGcprWv26yYkOsgWuC1cguDWE6HiHNi0PaiwD1IystipT/tZFYBhIV nK3uKitnkec/gRpq8O8yLd9k+Qy3Gd91uh04yNUztjbtHX5gifHgLVdpB+uil92pGiWJW1xZFHC 7emlJYDsGbF2UoA4VTDIBW0NGp9E997hdfkH9PhfOLRfT6/EHC5g0QDsgq3X3cB0iR16njv1ias GzdKnSeFXNN3sHZmm9IlHK72kGgIoCEJ1uFr2ZV7FGNc7NyFyc37ukIR/jXj7Ocnfj2zYrs+zzO soNqIQvNEwIDnkvgWA== X-Google-Smtp-Source: AGHT+IEFNoscpJifUIbRm79CtTjEI1Z4p3K/K/Dr2dE8XHjjERVfWchWCXHJTO7qy4YXr0H8ApeneQ== X-Received: by 2002:a05:6808:13cc:b0:3eb:619f:1aca with SMTP id 5614622812f47-3ebcb367939mr219224b6e.40.1734386267348; Mon, 16 Dec 2024 13:57:47 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3ebb479d299sm1814982b6e.12.2024.12.16.13.57.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Dec 2024 13:57:45 -0800 (PST) Message-ID: <5e133bba-ee3e-498f-80ea-375dd857c057@baylibre.com> Date: Mon, 16 Dec 2024 15:57:44 -0600 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] iio: common: ssp_sensors: drop conditional optimization for simplicity To: Vasileios Amoiridis , jic23@kernel.org, lars@metafoo.de Cc: krzysztof.kozlowski@linaro.org, nuno.sa@analog.com, u.kleine-koenig@baylibre.com, abhashkumarjha123@gmail.com, jstephan@baylibre.com, jackoalan@gmail.com, k.wrona@samsung.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241214191421.94172-1-vassilisamir@gmail.com> <20241214191421.94172-4-vassilisamir@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20241214191421.94172-4-vassilisamir@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/14/24 1:14 PM, Vasileios Amoiridis wrote: > Drop conditional in favor of always calculating the timestamp value. > This simplifies the code and allows to drop usage of internal private > variable "scan_timestamp" of the struct iio_dev. > > Signed-off-by: Vasileios Amoiridis > --- > drivers/iio/common/ssp_sensors/ssp_iio.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/iio/common/ssp_sensors/ssp_iio.c b/drivers/iio/common/ssp_sensors/ssp_iio.c > index caa404edd9d0..6b86b5315694 100644 > --- a/drivers/iio/common/ssp_sensors/ssp_iio.c > +++ b/drivers/iio/common/ssp_sensors/ssp_iio.c > @@ -8,6 +8,8 @@ > #include > #include > #include > +#include > +#include > #include "ssp_iio_sensor.h" > > /** > @@ -70,7 +72,6 @@ EXPORT_SYMBOL_NS(ssp_common_buffer_postdisable, "IIO_SSP_SENSORS"); > int ssp_common_process_data(struct iio_dev *indio_dev, void *buf, > unsigned int len, int64_t timestamp) > { > - __le32 time; > int64_t calculated_time = 0; > struct ssp_sensor_data *spd = iio_priv(indio_dev); > > @@ -82,11 +83,7 @@ int ssp_common_process_data(struct iio_dev *indio_dev, void *buf, > */ > memcpy(spd->buffer, buf, len); > > - if (indio_dev->scan_timestamp) { > - memcpy(&time, &((char *)buf)[len], SSP_TIME_SIZE); > - calculated_time = > - timestamp + (int64_t)le32_to_cpu(time) * 1000000; > - } > + calculated_time = timestamp + get_unaligned_le32(buf + len) * MEGA; Don't we still need to cast to 64 bit to avoid multiplication overflow? > > return iio_push_to_buffers_with_timestamp(indio_dev, spd->buffer, > calculated_time);