From: Frank Zago <frank@zago.net>
To: "Aditya Dutt" <duttaditya18@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: position: Add support for ams AS5600 angle sensor
Date: Mon, 20 Oct 2025 18:45:14 -0500 [thread overview]
Message-ID: <5f2f9957-52e1-43a6-b3f0-bd3f4e434ff6@zago.net> (raw)
In-Reply-To: <20251020201653.86181-3-duttaditya18@gmail.com>
Hello,
Thanks for updating that driver and making the required changes. I tried to go back to it a few times but motivation was lost.
The commit message should say "position sensor", not "angle sensor", for consistency.
> diff --git a/drivers/iio/position/as5600.c b/drivers/iio/position/as5600.c
> new file mode 100644
> index 000000000000..fe716d521548
> --- /dev/null
> +++ b/drivers/iio/position/as5600.c
...
> + case AS5600_REG_RAW_ANGLE_L:
> + case AS5600_REG_ANGLE_L:
> + case AS5600_REG_AGC:
> + case AS5600_REG_MAGN_L:
> + mask = 0xFF;
> + break;
> + default:
> + /* Not a readable register */
> + return -EINVAL;
> + }
> +
> +
extra empty line
I believe you could add this to the second patch:
Acked-by: Frank Zago <frank@zago.net>
Best regards,
Frank.
next prev parent reply other threads:[~2025-10-21 0:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 20:16 [PATCH 0/2] New driver for ams AS5600 Position Sensor Aditya Dutt
2025-10-20 20:16 ` [PATCH 1/2] dt-bindings: iio: position: Add " Aditya Dutt
2025-10-22 17:50 ` Conor Dooley
2025-10-20 20:16 ` [PATCH 2/2] iio: position: Add support for ams AS5600 angle sensor Aditya Dutt
2025-10-20 23:45 ` Frank Zago [this message]
2025-10-21 11:38 ` kernel test robot
2025-10-21 12:14 ` kernel test robot
2025-10-23 18:16 ` Jonathan Cameron
2025-10-23 18:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f2f9957-52e1-43a6-b3f0-bd3f4e434ff6@zago.net \
--to=frank@zago.net \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=duttaditya18@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox