linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/4] iio: chemical: add particle number concentration channel type
@ 2017-02-05 15:01 Tomasz Duszynski
  2017-02-05 15:21 ` Peter Meerwald-Stadler
  0 siblings, 1 reply; 4+ messages in thread
From: Tomasz Duszynski @ 2017-02-05 15:01 UTC (permalink / raw)
  To: linux-kernel, linux-iio; +Cc: jic23, knaack.h, lars, pmeerw

This patch adds channel type for expressing particle number
concentration.

Signed-off-by: Tomasz Duszynski <tduszyns@gmail.com>
---
 Documentation/ABI/testing/sysfs-bus-iio | 7 +++++++
 drivers/iio/industrialio-core.c         | 1 +
 include/uapi/linux/iio/types.h          | 1 +
 3 files changed, 9 insertions(+)

diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
index 530809ccfacf..481771e585ee 100644
--- a/Documentation/ABI/testing/sysfs-bus-iio
+++ b/Documentation/ABI/testing/sysfs-bus-iio
@@ -1608,3 +1608,10 @@ Description:
 		provides an absolute positional reference (e.g. a pulse once per
 		revolution) which may be used to home positional systems as
 		required.
+
+What:		/sys/bus/iio/devices/iio:deviceX/in_numberconcentration_input
+KernelVersion: 	4.12
+Contact:	linux-iio@vger.kernel.org
+Description:
+		Reading of particulates number in a volume of a mixture.
+		Unit is in 1/m3.
diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index d18ded45bedd..451e3bb8d623 100644
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -85,6 +85,7 @@ static const char * const iio_chan_type_name_spec[] = {
 	[IIO_COUNT] = "count",
 	[IIO_INDEX] = "index",
 	[IIO_GRAVITY]  = "gravity",
+	[IIO_NUMBERCONCENTRATION] = "numberconcentration",
 };
 
 static const char * const iio_modifier_names[] = {
diff --git a/include/uapi/linux/iio/types.h b/include/uapi/linux/iio/types.h
index ffafd6c25a48..52696e251c4d 100644
--- a/include/uapi/linux/iio/types.h
+++ b/include/uapi/linux/iio/types.h
@@ -43,6 +43,7 @@ enum iio_chan_type {
 	IIO_COUNT,
 	IIO_INDEX,
 	IIO_GRAVITY,
+	IIO_NUMBERCONCENTRATION,
 };
 
 enum iio_modifier {
-- 
2.11.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/4] iio: chemical: add particle number concentration channel type
  2017-02-05 15:01 [PATCH 1/4] iio: chemical: add particle number concentration channel type Tomasz Duszynski
@ 2017-02-05 15:21 ` Peter Meerwald-Stadler
  2017-02-05 16:06   ` Tomasz Duszynski
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Meerwald-Stadler @ 2017-02-05 15:21 UTC (permalink / raw)
  To: Tomasz Duszynski; +Cc: linux-kernel, linux-iio, jic23, knaack.h, lars


> This patch adds channel type for expressing particle number
> concentration.

numberconcentration sound a bit strange to be, more like a number 
theoretic concept

how about particlecontentration? or numberparticles?
 
> Signed-off-by: Tomasz Duszynski <tduszyns@gmail.com>
> ---
>  Documentation/ABI/testing/sysfs-bus-iio | 7 +++++++
>  drivers/iio/industrialio-core.c         | 1 +
>  include/uapi/linux/iio/types.h          | 1 +
>  3 files changed, 9 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index 530809ccfacf..481771e585ee 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -1608,3 +1608,10 @@ Description:
>  		provides an absolute positional reference (e.g. a pulse once per
>  		revolution) which may be used to home positional systems as
>  		required.
> +
> +What:		/sys/bus/iio/devices/iio:deviceX/in_numberconcentration_input
> +KernelVersion: 	4.12
> +Contact:	linux-iio@vger.kernel.org
> +Description:
> +		Reading of particulates number in a volume of a mixture.
> +		Unit is in 1/m3.
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index d18ded45bedd..451e3bb8d623 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -85,6 +85,7 @@ static const char * const iio_chan_type_name_spec[] = {
>  	[IIO_COUNT] = "count",
>  	[IIO_INDEX] = "index",
>  	[IIO_GRAVITY]  = "gravity",
> +	[IIO_NUMBERCONCENTRATION] = "numberconcentration",
>  };
>  
>  static const char * const iio_modifier_names[] = {
> diff --git a/include/uapi/linux/iio/types.h b/include/uapi/linux/iio/types.h
> index ffafd6c25a48..52696e251c4d 100644
> --- a/include/uapi/linux/iio/types.h
> +++ b/include/uapi/linux/iio/types.h
> @@ -43,6 +43,7 @@ enum iio_chan_type {
>  	IIO_COUNT,
>  	IIO_INDEX,
>  	IIO_GRAVITY,
> +	IIO_NUMBERCONCENTRATION,
>  };
>  
>  enum iio_modifier {
> 

-- 

Peter Meerwald-Stadler
+43-664-2444418 (mobile)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/4] iio: chemical: add particle number concentration channel type
  2017-02-05 15:21 ` Peter Meerwald-Stadler
@ 2017-02-05 16:06   ` Tomasz Duszynski
  2017-02-11 10:32     ` Jonathan Cameron
  0 siblings, 1 reply; 4+ messages in thread
From: Tomasz Duszynski @ 2017-02-05 16:06 UTC (permalink / raw)
  To: Peter Meerwald-Stadler
  Cc: Tomasz Duszynski, linux-kernel, linux-iio, jic23, knaack.h, lars

On Sun, Feb 05, 2017 at 04:21:27PM +0100, Peter Meerwald-Stadler wrote:
>
> > This patch adds channel type for expressing particle number
> > concentration.
>
> numberconcentration sound a bit strange to be, more like a number
> theoretic concept
>
> how about particlecontentration? or numberparticles?
>
Agree it may sound a bit strange but in fact it is a formal physical quantity
with SI unit. Perhaps I can leave it as is to stay consistent with
science world?
> > Signed-off-by: Tomasz Duszynski <tduszyns@gmail.com>
> > ---
> >  Documentation/ABI/testing/sysfs-bus-iio | 7 +++++++
> >  drivers/iio/industrialio-core.c         | 1 +
> >  include/uapi/linux/iio/types.h          | 1 +
> >  3 files changed, 9 insertions(+)
> >
> > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> > index 530809ccfacf..481771e585ee 100644
> > --- a/Documentation/ABI/testing/sysfs-bus-iio
> > +++ b/Documentation/ABI/testing/sysfs-bus-iio
> > @@ -1608,3 +1608,10 @@ Description:
> >  		provides an absolute positional reference (e.g. a pulse once per
> >  		revolution) which may be used to home positional systems as
> >  		required.
> > +
> > +What:		/sys/bus/iio/devices/iio:deviceX/in_numberconcentration_input
> > +KernelVersion: 	4.12
> > +Contact:	linux-iio@vger.kernel.org
> > +Description:
> > +		Reading of particulates number in a volume of a mixture.
> > +		Unit is in 1/m3.
> > diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> > index d18ded45bedd..451e3bb8d623 100644
> > --- a/drivers/iio/industrialio-core.c
> > +++ b/drivers/iio/industrialio-core.c
> > @@ -85,6 +85,7 @@ static const char * const iio_chan_type_name_spec[] = {
> >  	[IIO_COUNT] = "count",
> >  	[IIO_INDEX] = "index",
> >  	[IIO_GRAVITY]  = "gravity",
> > +	[IIO_NUMBERCONCENTRATION] = "numberconcentration",
> >  };
> >
> >  static const char * const iio_modifier_names[] = {
> > diff --git a/include/uapi/linux/iio/types.h b/include/uapi/linux/iio/types.h
> > index ffafd6c25a48..52696e251c4d 100644
> > --- a/include/uapi/linux/iio/types.h
> > +++ b/include/uapi/linux/iio/types.h
> > @@ -43,6 +43,7 @@ enum iio_chan_type {
> >  	IIO_COUNT,
> >  	IIO_INDEX,
> >  	IIO_GRAVITY,
> > +	IIO_NUMBERCONCENTRATION,
> >  };
> >
> >  enum iio_modifier {
> >
>
> --
>
> Peter Meerwald-Stadler
> +43-664-2444418 (mobile)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/4] iio: chemical: add particle number concentration channel type
  2017-02-05 16:06   ` Tomasz Duszynski
@ 2017-02-11 10:32     ` Jonathan Cameron
  0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2017-02-11 10:32 UTC (permalink / raw)
  To: Tomasz Duszynski, Peter Meerwald-Stadler
  Cc: linux-kernel, linux-iio, knaack.h, lars

On 05/02/17 16:06, Tomasz Duszynski wrote:
> On Sun, Feb 05, 2017 at 04:21:27PM +0100, Peter Meerwald-Stadler wrote:
>>
>>> This patch adds channel type for expressing particle number
>>> concentration.
>>
>> numberconcentration sound a bit strange to be, more like a number
>> theoretic concept
>>
>> how about particlecontentration? or numberparticles?
>>
> Agree it may sound a bit strange but in fact it is a formal physical quantity
> with SI unit. Perhaps I can leave it as is to stay consistent with
> science world?
Wikipedia seems to suggest that there are several choices, but this is
a common one in Chemistry so fair enough.

Jonathan
>>> Signed-off-by: Tomasz Duszynski <tduszyns@gmail.com>
>>> ---
>>>  Documentation/ABI/testing/sysfs-bus-iio | 7 +++++++
>>>  drivers/iio/industrialio-core.c         | 1 +
>>>  include/uapi/linux/iio/types.h          | 1 +
>>>  3 files changed, 9 insertions(+)
>>>
>>> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
>>> index 530809ccfacf..481771e585ee 100644
>>> --- a/Documentation/ABI/testing/sysfs-bus-iio
>>> +++ b/Documentation/ABI/testing/sysfs-bus-iio
>>> @@ -1608,3 +1608,10 @@ Description:
>>>  		provides an absolute positional reference (e.g. a pulse once per
>>>  		revolution) which may be used to home positional systems as
>>>  		required.
>>> +
>>> +What:		/sys/bus/iio/devices/iio:deviceX/in_numberconcentration_input
>>> +KernelVersion: 	4.12
>>> +Contact:	linux-iio@vger.kernel.org
>>> +Description:
>>> +		Reading of particulates number in a volume of a mixture.
>>> +		Unit is in 1/m3.
>>> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
>>> index d18ded45bedd..451e3bb8d623 100644
>>> --- a/drivers/iio/industrialio-core.c
>>> +++ b/drivers/iio/industrialio-core.c
>>> @@ -85,6 +85,7 @@ static const char * const iio_chan_type_name_spec[] = {
>>>  	[IIO_COUNT] = "count",
>>>  	[IIO_INDEX] = "index",
>>>  	[IIO_GRAVITY]  = "gravity",
>>> +	[IIO_NUMBERCONCENTRATION] = "numberconcentration",
>>>  };
>>>
>>>  static const char * const iio_modifier_names[] = {
>>> diff --git a/include/uapi/linux/iio/types.h b/include/uapi/linux/iio/types.h
>>> index ffafd6c25a48..52696e251c4d 100644
>>> --- a/include/uapi/linux/iio/types.h
>>> +++ b/include/uapi/linux/iio/types.h
>>> @@ -43,6 +43,7 @@ enum iio_chan_type {
>>>  	IIO_COUNT,
>>>  	IIO_INDEX,
>>>  	IIO_GRAVITY,
>>> +	IIO_NUMBERCONCENTRATION,
>>>  };
>>>
>>>  enum iio_modifier {
>>>
>>
>> --
>>
>> Peter Meerwald-Stadler
>> +43-664-2444418 (mobile)


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-02-11 10:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-05 15:01 [PATCH 1/4] iio: chemical: add particle number concentration channel type Tomasz Duszynski
2017-02-05 15:21 ` Peter Meerwald-Stadler
2017-02-05 16:06   ` Tomasz Duszynski
2017-02-11 10:32     ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).