From: David Lechner <david@lechnology.com>
To: Lars-Peter Clausen <lars@metafoo.de>,
Jonathan Cameron <jic23@kernel.org>
Cc: Justin Chen <justinpopo6@gmail.com>, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ti-ads7950: Set `can_sleep` flag for GPIO chip
Date: Mon, 13 Mar 2023 13:44:33 -0500 [thread overview]
Message-ID: <603a73ae-5c67-0837-ed26-9a98ad3fec74@lechnology.com> (raw)
In-Reply-To: <20230312210933.2275376-1-lars@metafoo.de>
On 3/12/23 4:09 PM, Lars-Peter Clausen wrote:
> The ads7950 uses a mutex as well as SPI transfers in its GPIO callbacks.
> This means these callbacks can sleep and the `can_sleep` flag should be
> set.
>
> Having the flag set will make sure that warnings are generated when calling
> any of the callbacks from a potentially non-sleeping context.
>
> Fixes: c97dce792dc8 ("iio: adc: ti-ads7950: add GPIO support")
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
Acked-by: David Lechner <david@lechnology.com>
next prev parent reply other threads:[~2023-03-13 19:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 21:09 [PATCH] iio: adc: ti-ads7950: Set `can_sleep` flag for GPIO chip Lars-Peter Clausen
2023-03-13 18:44 ` David Lechner [this message]
2023-03-18 16:40 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=603a73ae-5c67-0837-ed26-9a98ad3fec74@lechnology.com \
--to=david@lechnology.com \
--cc=jic23@kernel.org \
--cc=justinpopo6@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox