From: "Sean Nyekjær" <sean.nyekjaer@prevas.dk>
To: Colin King <colin.king@canonical.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: dac: remove redundant variable 'shift'
Date: Mon, 2 Jul 2018 12:43:20 +0200 [thread overview]
Message-ID: <62141c55-575a-d068-360a-e0ea53df6f17@prevas.dk> (raw)
In-Reply-To: <20180702102435.16724-1-colin.king@canonical.com>
On 2018-07-02 12:24, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable shift is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up two clang warnings:
> warning: variable ‘shift’ set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
Good catch :-)
BR
/Sean
next prev parent reply other threads:[~2018-07-02 10:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 10:24 [PATCH] iio: dac: remove redundant variable 'shift' Colin King
2018-07-02 10:43 ` Sean Nyekjær [this message]
2018-07-07 16:45 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62141c55-575a-d068-360a-e0ea53df6f17@prevas.dk \
--to=sean.nyekjaer@prevas.dk \
--cc=colin.king@canonical.com \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox