From: David Lechner <dlechner@baylibre.com>
To: "Ben Collins" <bcollins@watter.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Andrew Hepp" <andrew.hepp@ahepp.dev>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: iio: mcp9600: Add compatible for microchip,mcp9601
Date: Wed, 13 Aug 2025 16:11:59 -0500 [thread overview]
Message-ID: <623c0ef4-98c0-410c-abf3-fa9563f52688@baylibre.com> (raw)
In-Reply-To: <20250813151614.12098-2-bcollins@watter.com>
On 8/13/25 10:15 AM, Ben Collins wrote:
> MCP9601 is a superset of MCP9600 and is supported by the driver.
>
> Signed-off-by: Ben Collins <bcollins@watter.com>
> ---
Please include a cover letter with a changelog in v3.
> .../bindings/iio/temperature/microchip,mcp9600.yaml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/temperature/microchip,mcp9600.yaml b/Documentation/devicetree/bindings/iio/temperature/microchip,mcp9600.yaml
> index d2cafa38a5442..d8af0912ce886 100644
> --- a/Documentation/devicetree/bindings/iio/temperature/microchip,mcp9600.yaml
> +++ b/Documentation/devicetree/bindings/iio/temperature/microchip,mcp9600.yaml
> @@ -4,7 +4,7 @@
> $id: http://devicetree.org/schemas/iio/temperature/microchip,mcp9600.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: Microchip MCP9600 thermocouple EMF converter
> +title: Microchip MCP9600 and similar thermocouple EMF converters
>
> maintainers:
> - Andrew Hepp <andrew.hepp@ahepp.dev>
> @@ -14,7 +14,9 @@ description:
>
> properties:
> compatible:
> - const: microchip,mcp9600
> + enum:
> + - microchip,mcp9600
> + - microchip,mcp9601
>
It sounds like it would be useful to have a fallback in this case:
properties:
compatible:
oneOf:
- const: microchip,mcp9600
- items:
- - microchip,mcp9600
- microchip,mcp9600
> reg:
> maxItems: 1
Usage would then be:
compatible = "microchip,mcp9601", "microchip,mcp9600";
next prev parent reply other threads:[~2025-08-13 21:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250813151614.12098-1-bcollins@watter.com>
2025-08-13 15:15 ` [PATCH v2 1/5] dt-bindings: iio: mcp9600: Add compatible for microchip,mcp9601 Ben Collins
2025-08-13 16:15 ` Krzysztof Kozlowski
2025-08-13 21:11 ` David Lechner [this message]
[not found] ` <2025081319-abiding-muskox-c434f3@boujee-and-buff>
2025-08-16 18:43 ` David Lechner
2025-08-13 15:15 ` [PATCH v2 2/5] iio: mcp9600: White space cleanup for tab alignment Ben Collins
2025-08-13 16:34 ` Andy Shevchenko
2025-08-13 15:15 ` [PATCH v2 3/5] iio: mcp9600: Add compatibility for mcp9601 Ben Collins
2025-08-13 16:40 ` Andy Shevchenko
2025-08-13 15:15 ` [PATCH v2 4/5] iio: mcp9600: Add support for dtbinding of thermocouple-type Ben Collins
2025-08-13 16:49 ` Andy Shevchenko
2025-08-13 21:19 ` David Lechner
2025-08-13 15:15 ` [PATCH v2 5/5] iio: mcp9600: Add support for IIR filter Ben Collins
2025-08-13 16:53 ` Andy Shevchenko
2025-08-13 22:52 ` David Lechner
2025-08-14 13:06 ` Ben Collins
2025-08-14 13:38 ` Ben Collins
2025-08-16 9:54 ` Jonathan Cameron
2025-08-16 13:12 ` Ben Collins
2025-08-16 15:08 ` Jonathan Cameron
2025-08-16 15:19 ` Ben Collins
2025-08-16 15:33 ` Ben Collins
2025-08-16 17:16 ` David Lechner
2025-08-17 17:11 ` Jonathan Cameron
2025-08-17 17:13 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=623c0ef4-98c0-410c-abf3-fa9563f52688@baylibre.com \
--to=dlechner@baylibre.com \
--cc=andrew.hepp@ahepp.dev \
--cc=andy@kernel.org \
--cc=bcollins@watter.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox