From: Astrid Rost <astrid.rost@axis.com>
To: Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>
Cc: linux-iio@vger.kernel.org, "Nuno Sá" <noname.nuno@gmail.com>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Per-Daniel Olsson" <perdaniel.olsson@axis.com>,
"Javier Carrasco" <javier.carrasco.cruz@gmail.com>,
"Subhajit Ghosh" <subhajit.ghosh@tweaklogic.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 17/18] iio: light: vcnl4000: Switch to sparse friendly iio_device_claim/release_direct()
Date: Wed, 2 Apr 2025 09:28:59 +0200 [thread overview]
Message-ID: <6336de27-dbc3-421c-bed0-fa053831db7e@axis.com> (raw)
In-Reply-To: <20250331124408.69c27d42@jic23-huawei>
On 3/31/25 13:44, Jonathan Cameron wrote:
> On Tue, 11 Mar 2025 14:11:16 -0500
> David Lechner <dlechner@baylibre.com> wrote:
>
>> On 3/9/25 12:06 PM, Jonathan Cameron wrote:
>>> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>>>
>>> These new functions allow sparse to find failures to release
>>> direct mode reducing chances of bugs over the claim_direct_mode()
>>> functions that are deprecated.
>>>
>>> Also split the enabling and disabling of thresholds into separate
>>> functions given overlap is small.
>>
>> Should be 2 patches since doing 2 different things?
>
> They are messily overlapped because of the oddity that we only
> take the direct mode state if enabling. It is in theory possible to
> do the split of functions first but that will result in messier functions
> that we then clean up. I'm not keen on that complexity so going to be
> lazy this time and not do it.
>
> I'll add something to the patch description to say that.
>
> Jonathan
>
>
>>
>>>
>>> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>>> Cc: Astrid Rost <astrid.rost@axis.com>
>>> ---
>
Looks good to me also with one patch.
Reviewed-by: Astrid Rost <astrid.rost@axis.com>
next prev parent reply other threads:[~2025-04-02 7:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-09 17:06 [PATCH 00/18] iio: light: Sparse friendly claim of direct mode Jonathan Cameron
2025-03-09 17:06 ` [PATCH 01/18] iio: light: apds9306: Switch to sparse friendly iio_device_claim/release_direct() Jonathan Cameron
2025-03-10 6:35 ` Subhajit Ghosh
2025-03-10 20:01 ` Jonathan Cameron
2025-03-15 16:18 ` Subhajit Ghosh
2025-03-09 17:06 ` [PATCH 02/18] iio: light: gp2ap020a00f: " Jonathan Cameron
2025-03-09 17:06 ` [PATCH 03/18] iio: light: isl29125: " Jonathan Cameron
2025-03-09 17:06 ` [PATCH 04/18] iio: light: as73211: Use guard() and move mode switch into inner write_raw fucntion Jonathan Cameron
2025-03-11 18:55 ` David Lechner
2025-03-09 17:06 ` [PATCH 05/18] iio: light: as73211: Switch to sparse friendly iio_device_claim/release_direct() Jonathan Cameron
2025-03-09 17:06 ` [PATCH 06/18] iio: light: ltr501: Factor out IIO_INFO_RAW leg of read_raw() callback Jonathan Cameron
2025-03-09 17:06 ` [PATCH 07/18] iio: light: ltr501: Factor out core of write_raw() where direct mode claim is held Jonathan Cameron
2025-03-09 17:06 ` [PATCH 08/18] iio: light: ltr501: Switch to sparse friendly iio_device_claim/release_direct() Jonathan Cameron
2025-03-09 17:06 ` [PATCH 09/18] iio: light: opt4060: " Jonathan Cameron
2025-03-18 8:10 ` Per-Daniel Olsson
2025-03-18 17:07 ` Per-Daniel Olsson
2025-03-09 17:06 ` [PATCH 10/18] iio: light: rohm-bu27034: " Jonathan Cameron
2025-03-10 5:21 ` Matti Vaittinen
2025-03-09 17:06 ` [PATCH 11/18] iio: light: rpr0521: Factor out handling of IIO_INFO_RAW and use guard() Jonathan Cameron
2025-03-09 17:06 ` [PATCH 12/18] iio: light: rpr0521: Switch to sparse friendly iio_device_claim/release_direct() Jonathan Cameron
2025-03-09 17:06 ` [PATCH 13/18] iio: light: si1145: " Jonathan Cameron
2025-03-09 17:06 ` [PATCH 14/18] iio: light: st_uvis25: " Jonathan Cameron
2025-03-09 17:06 ` [PATCH 15/18] iio: light: tcs3414: " Jonathan Cameron
2025-03-09 17:06 ` [PATCH 16/18] iio: light: tcs3472: " Jonathan Cameron
2025-03-09 17:06 ` [PATCH 17/18] iio: light: vcnl4000: " Jonathan Cameron
2025-03-11 19:11 ` David Lechner
2025-03-31 11:44 ` Jonathan Cameron
2025-04-02 7:28 ` Astrid Rost [this message]
2025-03-18 17:08 ` Per-Daniel Olsson
2025-03-09 17:06 ` [PATCH 18/18] iio: light: vcnl4035: " Jonathan Cameron
2025-03-11 19:16 ` [PATCH 00/18] iio: light: Sparse friendly claim of direct mode David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6336de27-dbc3-421c-bed0-fa053831db7e@axis.com \
--to=astrid.rost@axis.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=dlechner@baylibre.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=noname.nuno@gmail.com \
--cc=nuno.sa@analog.com \
--cc=perdaniel.olsson@axis.com \
--cc=subhajit.ghosh@tweaklogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).