From: Sean Nyekjaer <sean@geanix.com>
To: "Sa, Nuno" <Nuno.Sa@analog.com>,
"jic23@kernel.org" <jic23@kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [RFC PATCH 1/2] iio: accel: add support for FXLS8962AF/FXLS8964AF accelerometers
Date: Thu, 15 Apr 2021 19:51:06 +0200 [thread overview]
Message-ID: <634cf024-dc01-431a-4955-88b453e2c629@geanix.com> (raw)
In-Reply-To: <CY4PR03MB31127BA6AD9A0F7DCF295ED0994D9@CY4PR03MB3112.namprd03.prod.outlook.com>
On 15/04/2021 17.10, Sa, Nuno wrote:
>> + pm_runtime_enable(dev);
>> + pm_runtime_set_autosuspend_delay(dev,
>> FXLS8962AF_AUTO_SUSPEND_DELAY_MS);
>> + pm_runtime_use_autosuspend(dev);
> Maybe add devm_add_action_or_reset() here and after enabling the
> regulator and we can then ditch ' fxls8962af_core_remove ()'...
Thanks for the review :)
I'm think not able to ditch the fxls8962af_core_remove() I still have
the pm_runtime stuff or can they be removed via some devm_ functions?
/Sean
next prev parent reply other threads:[~2021-04-15 17:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 11:46 [RFC PATCH 1/2] iio: accel: add support for FXLS8962AF/FXLS8964AF accelerometers Sean Nyekjaer
2021-04-15 11:46 ` [RFC PATCH 2/2] dt-bindings: iio: accel: fxls8962af: add bindings Sean Nyekjaer
2021-04-15 15:25 ` Rob Herring
2021-04-15 15:28 ` Rob Herring
2021-04-15 12:50 ` [RFC PATCH 1/2] iio: accel: add support for FXLS8962AF/FXLS8964AF accelerometers Lars-Peter Clausen
2021-04-15 17:53 ` Sean Nyekjaer
2021-04-15 15:10 ` Sa, Nuno
2021-04-15 17:51 ` Sean Nyekjaer [this message]
2021-04-16 7:26 ` Sa, Nuno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=634cf024-dc01-431a-4955-88b453e2c629@geanix.com \
--to=sean@geanix.com \
--cc=Nuno.Sa@analog.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox