From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>, Crt Mori <cmo@melexis.com>,
linux-iio@vger.kernel.org
Cc: Daniel Baluta <daniel.baluta@intel.com>,
Gregor Boirie <gregor.boirie@parrot.com>,
Matt Ranostay <mranostay@gmail.com>,
Sean Nyekjaer <sean.nyekjaer@prevas.dk>,
Markus Pargmann <mpa@pengutronix.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Hartmut Knaack <knaack.h@gmx.de>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 2/2] iio: devm_regulator_get_optional never returns NULL
Date: Mon, 5 Sep 2016 21:10:27 +0100 [thread overview]
Message-ID: <63e36d57-74ff-c7a2-092c-47614b9301f1@kernel.org> (raw)
In-Reply-To: <e7fbc8a9-3a97-5712-f7f3-6346137282eb@metafoo.de>
On 05/09/16 11:33, Lars-Peter Clausen wrote:
> On 09/05/2016 11:14 AM, Crt Mori wrote:
>> This patch is inspired by a comment of Jonathan Cameron on patch of
>> Linus Walleij commit aeb55fff3891834e07a3144159a7298a19696af8 ("iio:
>> st_sensors: fetch and enable regulators unconditionally"). Because
>> changes made in this patch are actually reference generators they should
>> be using devm_regulator_get_optional, but if they do not explicitly set
>> the reference to NULL they should not be using IS_ERR_OR_NULL, but
>> simple IS_ERR check.
>>
>> Suggested-by: Lars-Peter Clausen <lars@metafoo.de>
>> Signed-off-by: Crt Mori <cmo@melexis.com>
>
> Looks good, thanks.
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-09-05 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 9:14 [PATCH v2 1/2] iio: fetch and enable regulators unconditionally Crt Mori
2016-09-05 9:14 ` [PATCH v2 2/2] iio: devm_regulator_get_optional never returns NULL Crt Mori
2016-09-05 9:55 ` Linus Walleij
2016-09-05 10:33 ` Lars-Peter Clausen
2016-09-05 20:10 ` Jonathan Cameron [this message]
2016-09-05 20:09 ` [PATCH v2 1/2] iio: fetch and enable regulators unconditionally Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63e36d57-74ff-c7a2-092c-47614b9301f1@kernel.org \
--to=jic23@kernel.org \
--cc=cmo@melexis.com \
--cc=daniel.baluta@intel.com \
--cc=gregor.boirie@parrot.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=mranostay@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=sean.nyekjaer@prevas.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).