From: Krzysztof Kozlowski <krzk@kernel.org>
To: mgonellabolduc@dimonoff.com, Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>
Cc: Mikael Gonella-Bolduc <m.gonella.bolduc@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
Hugo Villeneuve <hvilleneuve@dimonoff.com>
Subject: Re: [PATCH 1/2] dt-bindings: iio: light: Add APDS9160 binding
Date: Wed, 20 Nov 2024 18:22:43 +0100 [thread overview]
Message-ID: <63e8c591-023d-4f50-abe1-d6a85fd3044b@kernel.org> (raw)
In-Reply-To: <20241119-apds9160-driver-v1-1-fa00675b4ea4@dimonoff.com>
On 19/11/2024 21:36, Mikael Gonella-Bolduc via B4 Relay wrote:
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + vdd-supply: true
> +
> +additionalProperties: false
This goes after required:
> +
> +required:
> + - compatible
> + - reg
Supply not required?
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + apds9160@53 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "broadmobi,apds9160";
Use 4 spaces for example indentation. Or at least something consistent.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-20 17:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 20:36 [PATCH 0/2] Add support for Avago/Broadcom APDS9160 Mikael Gonella-Bolduc via B4 Relay
2024-11-19 20:36 ` [PATCH 1/2] dt-bindings: iio: light: Add APDS9160 binding Mikael Gonella-Bolduc via B4 Relay
2024-11-20 17:18 ` Conor Dooley
2024-11-20 17:23 ` Krzysztof Kozlowski
2024-11-20 20:26 ` Mikael Gonella-Bolduc
2024-11-21 7:52 ` Krzysztof Kozlowski
2024-11-20 17:22 ` Krzysztof Kozlowski [this message]
2024-11-24 19:26 ` Jonathan Cameron
2024-11-19 20:36 ` [PATCH 2/2] iio: light: Add APDS9160 ALS & Proximity sensor driver Mikael Gonella-Bolduc via B4 Relay
2024-11-20 17:33 ` Krzysztof Kozlowski
2024-11-21 12:12 ` Javier Carrasco
2024-11-22 15:09 ` kernel test robot
2024-11-24 21:15 ` Jonathan Cameron
2024-11-27 22:11 ` Mikael Gonella-Bolduc
2024-12-01 13:20 ` Jonathan Cameron
2024-12-02 8:22 ` Matti Vaittinen
2024-12-05 9:42 ` Matti Vaittinen
2024-12-06 16:20 ` Mikael Gonella-Bolduc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63e8c591-023d-4f50-abe1-d6a85fd3044b@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hvilleneuve@dimonoff.com \
--cc=jic23@kernel.org \
--cc=justinstitt@google.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=m.gonella.bolduc@gmail.com \
--cc=mgonellabolduc@dimonoff.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox