From: Harinath Nampally <harinath922@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Martin Kepplinger <martink@posteo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
knaack.h@gmx.de, lars@metafoo.de, gregkh@linuxfoundation.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
amsfield22@gmail.com
Subject: Re: [PATCH] iio: accel: mma8452: Bugfix to enbale and allow different events to work parallely.
Date: Fri, 18 Aug 2017 20:05:52 -0400 [thread overview]
Message-ID: <6473aa07-e3d6-5b2b-39d4-38456cf7b301@gmail.com> (raw)
In-Reply-To: <20170817154041.6292ea19@archlinux>
> This patch fixes by detaching the event related information from
> chip_info struct,
>>> and based on channel type and event direction the corresponding
> event configuration registers
>>> are picked dynamically. Hence multiple events can be handled in
> read/write callbacks.
>> which chip can have which event(s)?
> I am planning to add 'supported events' field in
> One small point. Don't put the word bugfix in the title (and fix
> spelling of enable!). I know this is obviously a false restriction
> on the driver, but it doesn't not work, it is just limited in features
> without this.
Sure, thanks for letting me know.
On 08/17/2017 10:40 AM, Jonathan Cameron wrote:
>>> This patch fixes by detaching the event related information from
>>> chip_info struct,
>>>>> and based on channel type and event direction the corresponding
>>> event configuration registers
>>>>> are picked dynamically. Hence multiple events can be handled in
>>> read/write callbacks.
>>>> which chip can have which event(s)?
>>> I am planning to add 'supported events' field in
> One small point. Don't put the word bugfix in the title (and fix
> spelling of enable!). I know this is obviously a false restriction
> on the driver, but it doesn't not work, it is just limited in features
> without this.
prev parent reply other threads:[~2017-08-19 0:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 22:44 [PATCH] iio: accel: mma8452: Bugfix to enbale and allow different events to work parallely Harinath Nampally
2017-08-16 13:12 ` Peter Meerwald-Stadler
2017-08-17 0:39 ` Harinath Nampally
2017-08-17 11:24 ` Martin Kepplinger
2017-08-17 11:55 ` Harinath Nampally
2017-08-17 14:40 ` Jonathan Cameron
2017-08-19 0:05 ` Harinath Nampally [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6473aa07-e3d6-5b2b-39d4-38456cf7b301@gmail.com \
--to=harinath922@gmail.com \
--cc=amsfield22@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martink@posteo.de \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).