From: "Phani A, Rama Krishna" <rphani@codeaurora.org>
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio:adc:qcom-spmi-vadc: use div64_s64 instead of direct 64 bit division.
Date: Thu, 19 Jan 2017 15:55:48 +0530 [thread overview]
Message-ID: <6619ef49-ddf7-373a-1db7-2465fa4018b9@codeaurora.org> (raw)
In-Reply-To: <68e5dad4-366b-fc4a-e808-975953251b66@kernel.org>
Hi Jonathan,
Sorry for delayed response.
Verified the patches and are working fine.
Thanks for posting the changes .
Thanks,
Ramakrishna
On 11-Jan-17 11:08 PM, Jonathan Cameron wrote:
> On 08/01/17 21:06, Jonathan Cameron wrote:
>> Another one of these that we missed previously which prevents test builds
>> of this driver on 32 bit platforms as it gives an undefined __divdi3 warning.
>>
> I'm going to apply (well actually I already did by accident) this
> one and send a pull request to Greg.
>
> We are far enough into the cycle that I want to start getting stuff
> into linux-next.
>
> Rama, if you get a chance, please do test the 3 patches I've added
> to fix up build issues for this driver.
>
> Thanks,
>
> Jonathan
>> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
>> ---
>> drivers/iio/adc/qcom-spmi-vadc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/adc/qcom-spmi-vadc.c b/drivers/iio/adc/qcom-spmi-vadc.c
>> index faaf711325b5..0a19761d656c 100644
>> --- a/drivers/iio/adc/qcom-spmi-vadc.c
>> +++ b/drivers/iio/adc/qcom-spmi-vadc.c
>> @@ -641,7 +641,7 @@ static int vadc_scale_therm(struct vadc_priv *vadc,
>> vadc_scale_calib(vadc, adc_code, prop, &voltage);
>>
>> if (prop->calibration == VADC_CALIB_ABSOLUTE)
>> - voltage /= 1000;
>> + voltage = div64_s64(voltage, 1000);
>>
>> vadc_map_voltage_temp(adcmap_100k_104ef_104fb,
>> ARRAY_SIZE(adcmap_100k_104ef_104fb),
>>
>
prev parent reply other threads:[~2017-01-19 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-08 21:06 [PATCH] iio:adc:qcom-spmi-vadc: use div64_s64 instead of direct 64 bit division Jonathan Cameron
2017-01-11 17:38 ` Jonathan Cameron
2017-01-19 10:25 ` Phani A, Rama Krishna [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6619ef49-ddf7-373a-1db7-2465fa4018b9@codeaurora.org \
--to=rphani@codeaurora.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).