From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4BA5C48BD6 for ; Wed, 26 Jun 2019 15:30:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77C0F2133F for ; Wed, 26 Jun 2019 15:30:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727139AbfFZPaC (ORCPT ); Wed, 26 Jun 2019 11:30:02 -0400 Received: from mga14.intel.com ([192.55.52.115]:26752 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725958AbfFZPaC (ORCPT ); Wed, 26 Jun 2019 11:30:02 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2019 08:30:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,420,1557212400"; d="scan'208";a="245459984" Received: from spandruv-desk.jf.intel.com ([10.54.75.31]) by orsmga001.jf.intel.com with ESMTP; 26 Jun 2019 08:30:01 -0700 Message-ID: <67a1ec6dd44866c29333f5b05184cc402bc20382.camel@linux.intel.com> Subject: Re: [PATCH v3] hid: remove NO_D3 flag when remove driver From: Srinivas Pandruvada To: Jiri Kosina , hongyan.song@intel.com Cc: linux-input@vger.kernel.org, linux-iio@vger.kernel.org, hdegoede@redhat.com, jic23@kernel.org, even.xu@intel.com Date: Wed, 26 Jun 2019 08:30:01 -0700 In-Reply-To: References: <1559434641-11783-1-git-send-email-hongyan.song@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-3.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, 2019-06-26 at 14:07 +0200, Jiri Kosina wrote: > On Sun, 2 Jun 2019, hongyan.song@intel.com wrote: > > > From: Song Hongyan > > > > Remove the NO_D3 flag when remove the driver and let device enter > > into D3, it will save more power. > > > > Signed-off-by: Song Hongyan > > Acked-by: Srinivas Pandruvada > > --- > > v3 changes: > > After test the former implmentation, we found FW will enter D3 when > > system enter into S0i3. Change the implementation to meet the > > requirement: > > device enter D3 and have no impact to ISH platform. > > Srinivas, I'd prefer changes like this to go to Linus tree in merge > window > and not -rc phase, so I'll do that unless you tell me there is a > good > reason to push it to Linus still in -rc. Correct. I will tell you if it is important enough to go to -rc release, otherwise all changes you can assume for the next merge window. This change is also for the next merge window. Thanks, Srinivas > > Thanks, >