From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:35114 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750735AbdAUOUr (ORCPT ); Sat, 21 Jan 2017 09:20:47 -0500 Subject: Re: [PATCH] iio: health: max30100: use msleep() for long uncritical delays To: Matt Ranostay , Nicholas Mc Guire References: <1484580953-29817-1-git-send-email-hofrat@osadl.org> Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Matt Ranostay , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org From: Jonathan Cameron Message-ID: <683569ef-1f8c-02ad-337a-da7da8d6317e@kernel.org> Date: Sat, 21 Jan 2017 14:20:44 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 17/01/17 02:00, Matt Ranostay wrote: > On Mon, Jan 16, 2017 at 7:35 AM, Nicholas Mc Guire wrote: >> ulseep_range() uses hrtimers and provides no advantage over msleep() >> for larger delays. Fix up the 35ms delays here to use msleep() and >> reduce the load on the hrtimer subsystem. > > Ok makes sense. Also long as it guaranteed to be at least 35 milliseconds. > > Reviewed-by: Matt Ranostay Fair enough. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > >> >> Fixes: commit 4d33615df58b ("iio: light: add MAX30100 oximeter driver support") >> Link: http://lkml.org/lkml/2017/1/11/377 >> Signed-off-by: Nicholas Mc Guire >> --- >> Problem located with coccinelle script >> >> Patch was compile tested with: x86_64_defconfig + CONFIG_IIO=m + >> CONFIG_MAX30100=m >> >> Patch is aginast 4.10-rc3 (localversion-next is next-20170116) >> >> drivers/iio/health/max30100.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/iio/health/max30100.c b/drivers/iio/health/max30100.c >> index 90ab8a2d..9648c69 100644 >> --- a/drivers/iio/health/max30100.c >> +++ b/drivers/iio/health/max30100.c >> @@ -378,7 +378,7 @@ static int max30100_get_temp(struct max30100_data *data, int *val) >> if (ret) >> return ret; >> >> - usleep_range(35000, 50000); >> + msleep(35); >> >> return max30100_read_temp(data, val); >> } >> -- >> 2.1.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html