From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: ChiaEn Wu <peterwu.pub@gmail.com>,
pavel@ucw.cz, matthias.bgg@gmail.com, jic23@kernel.org,
lars@metafoo.de, andriy.shevchenko@linux.intel.com
Cc: chiaen_wu@richtek.com, alice_chen@richtek.com,
cy_huang@richtek.com, linux-leds@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, szunichen@gmail.com
Subject: Re: [PATCH v14 3/3] leds: flash: mt6370: Add MediaTek MT6370 flashlight support
Date: Tue, 11 Oct 2022 11:52:53 +0200 [thread overview]
Message-ID: <68ab0f05-e74a-e091-0109-09b57b90c652@collabora.com> (raw)
In-Reply-To: <657f73ae257925ebc68dc825998384ad79d31e1f.1665488982.git.chiaen_wu@richtek.com>
Il 11/10/22 06:05, ChiaEn Wu ha scritto:
> From: Alice Chen <alice_chen@richtek.com>
>
> The MediaTek MT6370 is a highly-integrated smart power management IC,
> which includes a single cell Li-Ion/Li-Polymer switching battery
> charger, a USB Type-C & Power Delivery (PD) controller, dual Flash
> LED current sources, a RGB LED driver, a backlight WLED driver,
> a display bias driver and a general LDO for portable devices.
>
> Add support for the MT6370 Flash LED driver. Flash LED in MT6370
> has 2 channels and support torch/strobe mode.
>
> Signed-off-by: Alice Chen <alice_chen@richtek.com>
> Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
> ---
>
> v14
> - Remove unused 'depend on OF' in Kconfig
> ---
> drivers/leds/flash/Kconfig | 14 +
> drivers/leds/flash/Makefile | 1 +
> drivers/leds/flash/leds-mt6370-flash.c | 631 +++++++++++++++++++++++++++++++++
> 3 files changed, 646 insertions(+)
> create mode 100644 drivers/leds/flash/leds-mt6370-flash.c
>
> diff --git a/drivers/leds/flash/Kconfig b/drivers/leds/flash/Kconfig
> index d3eb689..0dd955c 100644
> --- a/drivers/leds/flash/Kconfig
> +++ b/drivers/leds/flash/Kconfig
> @@ -61,6 +61,20 @@ config LEDS_MT6360
> Independent current sources supply for each flash LED support torch
> and strobe mode.
>
> +config LEDS_MT6370_FLASH
> + tristate "Flash LED Support for MediaTek MT6370 PMIC"
> + depends on LEDS_CLASS
> + depends on LEDS_CLASS_FLASH || !LEDS_CLASS_FLASH
This dependency makes no sense, as the options in the Kconfig you're putting
this into gets parsed only `if LEDS_CLASS_FLASH`.
Please remove that.
> + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
Well, if it depends on that being either y, m or n, it means that it does
not depend on that at all. Remove.
After which,
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> + depends on MFD_MT6370
> + help
> + Support 2 channels and torch/strobe mode.
> + Say Y here to enable support for
> + MT6370_FLASH_LED device.
> +
> + This driver can also be built as a module. If so, the module
> + will be called "leds-mt6370-flash".
> +
> config LEDS_RT4505
> tristate "LED support for RT4505 flashlight controller"
> depends on I2C && OF
next prev parent reply other threads:[~2022-10-11 9:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 4:05 [PATCH v14 0/3] Add MediaTek MT6370 PMIC support ChiaEn Wu
2022-10-11 4:05 ` [PATCH v14 1/3] iio: adc: mt6370: Add MediaTek MT6370 support ChiaEn Wu
2022-10-15 15:22 ` Jonathan Cameron
2022-10-11 4:05 ` [PATCH v14 2/3] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support ChiaEn Wu
2022-10-11 4:05 ` [PATCH v14 3/3] leds: flash: mt6370: Add MediaTek MT6370 flashlight support ChiaEn Wu
2022-10-11 9:52 ` AngeloGioacchino Del Regno [this message]
2022-10-11 11:02 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68ab0f05-e74a-e091-0109-09b57b90c652@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=alice_chen@richtek.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=chiaen_wu@richtek.com \
--cc=cy_huang@richtek.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=peterwu.pub@gmail.com \
--cc=szunichen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox