From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Nuno Sá" <nuno.sa@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>
Subject: Re: [PATCH v2 1/3] iio: temperature: ltc2983: Don't hard code defined constants in messages
Date: Mon, 07 Feb 2022 09:29:52 -0800 [thread overview]
Message-ID: <6937d748bb04b53b88d2f4363db31bed2ae7550a.camel@perches.com> (raw)
In-Reply-To: <YgFVFceYQtWq4Hww@smile.fi.intel.com>
On Mon, 2022-02-07 at 19:21 +0200, Andy Shevchenko wrote:
> On Mon, Feb 07, 2022 at 08:37:55AM -0800, Joe Perches wrote:
> > On Mon, 2022-02-07 at 12:48 +0200, Andy Shevchenko wrote:
> > > In a couple of messages the constants, which have their definitions,
> > > are hard coded into the message text. Unhardcode them.
> >
> > Found by inspection or tool?
>
> Does it matter?
Yes. If it was done using a tool, then it could used treewide.
> No, a side effect of the following patch.
k
next prev parent reply other threads:[~2022-02-07 17:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 10:48 [PATCH v2 1/3] iio: temperature: ltc2983: Don't hard code defined constants in messages Andy Shevchenko
2022-02-07 10:48 ` [PATCH v2 2/3] iio: temperature: ltc2983: Use single error path to put OF node Andy Shevchenko
2022-02-07 10:48 ` [PATCH v2 3/3] iio: temperature: ltc2983: Make use of device properties Andy Shevchenko
2022-02-07 16:37 ` [PATCH v2 1/3] iio: temperature: ltc2983: Don't hard code defined constants in messages Joe Perches
2022-02-07 17:21 ` Andy Shevchenko
2022-02-07 17:29 ` Joe Perches [this message]
2022-02-07 20:44 ` Jonathan Cameron
2022-02-10 13:54 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6937d748bb04b53b88d2f4363db31bed2ae7550a.camel@perches.com \
--to=joe@perches.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox