Re: [PATCH v2] iio: accel: adxl372: Add timestamp to FIFO data

[Md Shofiqul Islam <shofiqtest@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]

Hi David,

Thank you for the two review comments.

Regarding the timestamp accuracy concern from the v1 discussion: the commit
message in v3 now explicitly documents this. The timestamp is captured once
per FIFO watermark interrupt and reused for all samples drained in that
invocation. It is most accurate for the last sample in the burst and
progressively stale for earlier ones. This is noted as an acceptable
approximation for coarse event sequencing, consistent with watermark-based
FIFO readout in other IIO accelerometer drivers.

Regarding the function choice: Stepan Ionichev identified that
iio_push_to_buffers_with_ts() writes the timestamp directly into the source
buffer during the loop, corrupting subsequent FIFO entries. v3 switches to
iio_push_to_buffers_with_ts_unaligned() which copies into an internal bounce
buffer without modifying the caller's data. The size argument remains
st->fifo_set_size * sizeof(__be16) -- the actual per-sample data length --
which _unaligned() caps at min(scan_bytes, data_sz) internally.

v3 is at:
  [PATCH v3] iio: accel: adxl372: Add timestamp to FIFO data
  Message-ID: <20260517091735.135610-1-shofiqtest@gmail.com>

Md Shofiqul Islam